Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page
Summary: Remove YUI styling from buttons on the patron card creator's image manage page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/patroncards/image-manag...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 13:30 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page (7.35 KB, patch)
2013-02-22 14:01 UTC, Owen Leonard
Details | Diff | Splinter Review
pre-patch (25.50 KB, image/png)
2013-02-22 17:38 UTC, Bernardo Gonzalez Kriegel
Details
post-patch (22.96 KB, image/png)
2013-02-22 17:39 UTC, Bernardo Gonzalez Kriegel
Details
upload (8.56 KB, image/png)
2013-02-22 17:39 UTC, Bernardo Gonzalez Kriegel
Details
delete (5.13 KB, image/png)
2013-02-22 17:40 UTC, Bernardo Gonzalez Kriegel
Details
[SIGNED-OFF] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page (7.46 KB, patch)
2013-02-22 18:19 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page (7.55 KB, patch)
2013-03-02 17:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-22 13:30:56 UTC
Several buttons on the patron card creator's image manage page are styled using YUI. Typically we don't apply special button styling to submit buttons, so to make this page consistent with others in Koha I propose to remove YUI styling.
Comment 1 Owen Leonard 2013-02-22 14:01:02 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-22 17:38:29 UTC
Created attachment 15630 [details]
pre-patch
Comment 3 Bernardo Gonzalez Kriegel 2013-02-22 17:39:24 UTC
Created attachment 15631 [details]
post-patch
Comment 4 Bernardo Gonzalez Kriegel 2013-02-22 17:39:57 UTC
Created attachment 15632 [details]
upload
Comment 5 Bernardo Gonzalez Kriegel 2013-02-22 17:40:19 UTC
Created attachment 15633 [details]
delete
Comment 6 Bernardo Gonzalez Kriegel 2013-02-22 17:43:40 UTC
Hi,

1) Added pre and post screen. Is that (post) the final look? 

2) When you upload or delete a file, a box indicating the action appears, and a few seconds later disappears. With patch applied, they do not disappear any more.
Comment 7 Owen Leonard 2013-02-22 18:05:43 UTC
(In reply to comment #6)
> 1) Added pre and post screen. Is that (post) the final look? 

Yes: A submit button with default styling and a plain "cancel" link, consistent with other "save/cancel" pairs throughout Koha.
 
> 2) When you upload or delete a file, a box indicating the action appears,
> and a few seconds later disappears. With patch applied, they do not
> disappear any more.

This is a change peripheral to the patch, so I should have mentioned it: This kind of interface behavior is non-standard and I removed it rather than update it along with other JavaScript changes. The disappearing effect isn't required for functionality, leaving messages visible could be helpful to users who are not watching the screen constantly during these operations.
Comment 8 Bernardo Gonzalez Kriegel 2013-02-22 18:19:10 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2013-03-02 17:40:46 UTC
Created attachment 15829 [details] [review]
[PASSED QA] Bug 9693 - Remove YUI styling from buttons on the patron card creator's image manage page

Buttons on the patron card creator's image manage page are styled using
YUI. They can be classified as submit buttons rather than toolbar
buttons, so they should have default submit button styles.

This patch removes YUI styling and related JavaScript. Other minor
changes: Markup corrections for validity.

To test, view the patron card creator's image manage page. "Upload" and
"Delete" buttons should look correct and work correctly. Upload and
delete operations should function normally.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.
Questions answered in comments.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely and is more consistent.
Comment 10 Jared Camins-Esakov 2013-03-07 15:03:59 UTC
This patch has been pushed to master.