Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages
Summary: Remove YUI styling from buttons on the patron card creator manage pages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/patroncards/manage.pl?c...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 14:24 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages (5.03 KB, patch)
2013-02-22 14:30 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages (5.03 KB, patch)
2013-02-22 15:40 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages (5.16 KB, patch)
2013-02-22 17:56 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages (5.25 KB, patch)
2013-03-05 07:27 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-22 14:24:20 UTC
Several buttons on the patron card creator's manage page (used to manage layouts, profiles, etc) are styled using YUI. Typically we don't apply special button styling to submit buttons, so to make this page consistent with others in Koha I propose to remove YUI styling.
Comment 1 Owen Leonard 2013-02-22 14:30:59 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-02-22 15:40:16 UTC Comment hidden (obsolete)
Comment 3 Bernardo Gonzalez Kriegel 2013-02-22 17:56:32 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-03-05 07:27:38 UTC
Created attachment 15875 [details] [review]
[PASSED QA] Bug 9694 - Remove YUI styling from buttons on the patron card creator manage pages

Buttons on the patron card creator's manage pages (manage templates,
manage profiles, etc) are styled using YUI. They can be classified as
submit buttons rather than toolbar buttons, so they should have default
submit button styles.

This patch removes YUI styling and related JavaScript. Other minor
changes: Escaping strings in JavaScript for translation.

To test, view the patron card creator's manage page for layouts,
templates, profiles, and batches. "Edit," "Delete," and "Export" buttons
should look correct and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. On errors.
Tested all manage pages, edit, delete, and export buttons.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, improves consistency.
Comment 5 Jared Camins-Esakov 2013-03-07 14:57:54 UTC
This patch has been pushed to master.