Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap
Summary: Replace YUI buttons on patron card creator manage toolbar with Bootstrap
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL: /cgi-bin/koha/patroncards/manage.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-02-22 15:44 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap (4.30 KB, patch)
2013-02-22 15:54 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap (4.41 KB, patch)
2013-02-22 21:12 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap (4.54 KB, patch)
2013-03-05 07:20 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-02-22 15:44:46 UTC
The patron card creator home and manage pages use an include, patroncards-toolbar.inc, which uses YUI to style toolbar buttons. It should use Bootstrap instead.
Comment 1 Owen Leonard 2013-02-22 15:54:53 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-22 21:12:18 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-03-05 07:20:23 UTC
Created attachment 15874 [details] [review]
[PASSED QA] Bug 9698 - Replace YUI buttons on patron card creator manage toolbar with Bootstrap

This patch converts the toolbar include file used by the patron card
creator home and manage pages to Bootstrap, replacing YUI button and
menu code with Bootstrap markup.

This patch converts the previous menu buttons to plain buttons,
removing the redundant links to the manage pages, which are in the
left-hand sidebar. This keeps toolbar buttons within the general
category of "action" (as opposed to "view").

To test, view the patron card creator home page and any manage page
("Manage layouts," "Manage profiles," etc). Buttons should look correct
and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors.
No "plus" sign for this buttons?

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
No plus signs? :)
Works nicely and didn't have the plus before, so it's ok.
Comment 4 Jared Camins-Esakov 2013-03-07 14:52:43 UTC
This patch has been pushed to master.

Plus sign icons would be a nice follow-up.