Like said in Bug 5727 : A lot of 'Use of uninitialized value in concatenation (.) or string' pollute log files and make them unreadable. This warnings must be corrected in most used pages of circulation/members module.
Created attachment 15725 [details] [review] Proposed patch (circulation) Patch for circulation.pl. See commit comment
Created attachment 15726 [details] [review] Proposed patch (members) Patch for member pages. See commit comment
Created attachment 15735 [details] [review] Bug 9720 : uninitialized value warnings in circulation This patch corrects several uninitialized value errors. Test plan: - Go to check out page - Check that issues and old issues are in different tables - Check that author is diplayed if exists - Check that patron address is displayed if exists - Perform a checkout Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 15736 [details] [review] Bug 9720 : uninitialized value warnings in circulation (followup 1) This patch corrects several uninitialized value errors. Test plan: - Edit a borrower - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Edit an organisation (depends on borrower category) - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Go to a borrower page who has today issues - Click on More/Export today's checked in barcodes => You get a file to dowload Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Created attachment 17026 [details] [review] Bug 9720 : uninitialized value warnings in circulation This patch corrects several uninitialized value errors. Test plan: - Go to check out page - Check that issues and old issues are in different tables - Check that author is diplayed if exists - Check that patron address is displayed if exists - Perform a checkout Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 17027 [details] [review] Bug 9720 : uninitialized value warnings in circulation (followup 1) This patch corrects several uninitialized value errors. Test plan: - Edit a borrower - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Edit an organisation (depends on borrower category) - Enter a surname using lowercase (it will be displayed uppercase by CSS) and save => Borrower surname is uppercase - Go to a borrower page who has today issues - Click on More/Export today's checked in barcodes => You get a file to dowload Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: I am certainly in favor of removings warns! One small point: $data{'surname'} &&= uc( $data{'surname'} ); This is not a very clear construct. But it works. An if reads better.. Nothing to say. Looks good. Passed QA
This patch has been pushed to master. There are still some uninitialized value warnings in circ, but fewer: Use of uninitialized value in string ne at /home/jcamins/kohaclone/circ/circulation.pl line 393. Use of uninitialized value in string eq at /home/jcamins/kohaclone/circ/circulation.pl line 399. Use of uninitialized value in sprintf at /home/jcamins/kohaclone/circ/circulation.pl line 453. Use of uninitialized value in sprintf at /home/jcamins/kohaclone/circ/circulation.pl line 453. (if you decide to work on them, please open a new bug)
Pushed to 3.10.x will be in 3.10.6