Bug 9724 - Hourly loans don't show time due in SCO
Summary: Hourly loans don't show time due in SCO
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on: 9723
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-27 15:30 UTC by Kyle M Hall (khall)
Modified: 2014-12-07 20:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 9724 - Hourly loans don't show time due in SCO (3.59 KB, patch)
2014-04-24 16:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9724 - Hourly loans don't show time due in SCO (3.76 KB, patch)
2014-04-24 19:25 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 9724 - Hourly loans don't show time due in SCO (3.91 KB, patch)
2014-05-09 15:33 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 9724 - Hourly loans don't show time due in SCO (3.96 KB, patch)
2014-05-12 14:19 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall (khall) 2013-02-27 15:30:20 UTC
The time an item is due does not display in self-checkout.
Comment 1 Owen Leonard 2014-04-24 16:02:53 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2014-04-24 18:26:34 UTC
My comments to bug 9723 apply here as well.
Comment 3 Owen Leonard 2014-04-24 19:25:56 UTC Comment hidden (obsolete)
Comment 4 Marc Véron 2014-05-09 15:33:17 UTC
Created attachment 28143 [details] [review]
[Signed-off] Bug 9724 - Hourly loans don't show time due in SCO

Due dates in the self checkout module don't display the time items are
due, and thus items which are on hourly loans don't display an accurate
due date and time. This patch corrects this by adding the "as_due_date
=> 1" parameter added by Bug 9723.

To test, apply the patch for Bug 9723 if necessary. Enable an hourly
loan period for an itemtype in your collection. Log into the
self-checkout system and check out an item which circulates by the hour.
The due date and time should be displayed correctly.

Check out an item which does not circulate hourly. The due date should
be displayed as a date only.

Test in both prog and Bootstrap themes.

Followed test plan. Wors as expected.
Signed-off-by: Marc Véron <veron@veron.ch>
Comment 5 Jonathan Druart 2014-05-12 14:19:21 UTC
Created attachment 28178 [details] [review]
Bug 9724 - Hourly loans don't show time due in SCO

Due dates in the self checkout module don't display the time items are
due, and thus items which are on hourly loans don't display an accurate
due date and time. This patch corrects this by adding the "as_due_date
=> 1" parameter added by Bug 9723.

To test, apply the patch for Bug 9723 if necessary. Enable an hourly
loan period for an itemtype in your collection. Log into the
self-checkout system and check out an item which circulates by the hour.
The due date and time should be displayed correctly.

Check out an item which does not circulate hourly. The due date should
be displayed as a date only.

Test in both prog and Bootstrap themes.

Followed test plan. Wors as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 6 Galen Charlton 2014-05-12 14:33:12 UTC
Pushed to master.  Thanks, Owen!