Bug 9748 - noitemlinks not being enforced
Summary: noitemlinks not being enforced
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-05 19:07 UTC by Kyle M Hall
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9748 - noitemlinks not being enforced (1.92 KB, patch)
2013-03-05 19:10 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 9748: don't link items in SCO checkout list back to main OPAC (1.99 KB, patch)
2013-03-12 23:22 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 9748: don't link items in SCO checkout list back to main OPAC (1.99 KB, patch)
2013-03-19 15:11 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-03-05 19:07:35 UTC
It appears that the conversion from HTML::Template to TT changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored.
Comment 1 Kyle M Hall 2013-03-05 19:10:00 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-03-12 23:22:29 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-03-19 15:11:14 UTC
QA comment:

I don't understand why links are hidden and how they can be shown (when noitemlinks is false?), but it was the excepted behavior before the conversion to TT.

Marked as Passed QA.
Comment 4 Jonathan Druart 2013-03-19 15:11:36 UTC
Created attachment 16405 [details] [review]
Bug 9748: don't link items in SCO checkout list back to main OPAC

It appears that the conversion from HTML::Template to TT
changed noitemlinks to ISSUE.noitemlinks, hence it is being ignored.

This is a problem for SCO kiosks where all the navigation controls
are hidden. Clicking the link means leaving the SCO module and
not being able to get back.

Test plan:
1) Run SCO module, check for item links
2) Apply patch
3) Run SCO module, note that the items no longer have links

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Comment 5 Jared Camins-Esakov 2013-03-20 12:58:06 UTC
This patch has been pushed to master.
Comment 6 Chris Cormack 2013-03-29 06:53:02 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12