Bug 9751 - Patron flags red in moremember.pl like in circulation.pl
Summary: Patron flags red in moremember.pl like in circulation.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Fridolin Somers
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-06 10:20 UTC by Fridolin Somers
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed patch (2.53 KB, patch)
2013-03-06 10:26 UTC, Fridolin Somers 		Details | Diff | Splinter Review
screen-shot with patch (64.81 KB, image/png)
2013-03-06 10:30 UTC, Fridolin Somers 		Details
Bug 9751: Patron flags red in moremember.pl like in circulation.pl (2.57 KB, patch)
2013-03-08 16:03 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Check out tab for a patron with flags set (25.01 KB, image/png)
2013-03-20 11:13 UTC, Katrin Fischer 		Details
Details tab for a patron with flags set (8.16 KB, image/png)
2013-03-20 11:14 UTC, Katrin Fischer 		Details
[PASSED QA] Bug 9751: Patron flags red in moremember.pl like in circulation.pl (2.70 KB, patch)
2013-03-20 11:18 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2013-03-06 10:20:55 UTC 
In a patron detail page (moremember.pl), when looking at a patron with one or more flags, for example :
 . Patron is restricted until 30/03/2013 (debarr comment)
 . Patron's address is in doubt.
 . Patron's card has been reported lost.
Click on Check out tab and look at circulation page : flags are red. It is more attractive for librarian.
Comment 1 Fridolin Somers 2013-03-06 10:26:20 UTC Comment hidden (obsolete)
Comment 2 Fridolin Somers 2013-03-06 10:30:08 UTC 
Created attachment 15904 [details]
screen-shot with patch
Comment 3 Kyle M Hall (khall) 2013-03-08 16:03:24 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-03-20 11:13:22 UTC 
Created attachment 16494 [details]
Check out tab for a patron with flags set
Comment 5 Katrin Fischer 2013-03-20 11:14:56 UTC 
Created attachment 16495 [details]
Details tab for a patron with flags set

The patch is an improvement, as it makes the flags display more consistent, but there are still some differences I wanted to show with those 2 screenshots.

Passing QA on this as it is an improvement :)
Comment 6 Katrin Fischer 2013-03-20 11:18:24 UTC 
Created attachment 16496 [details] [review]
[PASSED QA] Bug 9751: Patron flags red in moremember.pl like in circulation.pl

In a patron detail page (moremember.pl), when looking at a patron with one or more flags.
Click on Check out tab and look at circulation page : flags are red. It is more attractive for librarian.

This patch add CSS classes to patron flags in moremember.pl so they look more like circulation.pl :
- red color
- custom list bullets

Test plan ;
- Set to a patron all flags.
- Go to detail page of this patron
=> Check all flags are red and bullets are like ">"

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch makes display more consistent and passes all tests.
Comment 7 Jared Camins-Esakov 2013-03-20 19:20:50 UTC 
This patch has been pushed to master.