A lot of code in systempreferences.pl should be obsoleted. It is the old code for preferences. Only code pertaining to local use preferences should be kept.
Created attachment 15928 [details] [review] Bug 9760: Simplify local use preferences Removes a lot of code that was needed to handle prefs the old way. Test plan: Goto Local use preferences. Do you see some local preferences? Add a new pref, edit and delete it. Modify the url to systempreferences.pl?tab=OPAC or tab=log. You should only see a short message.
Created attachment 15983 [details] [review] Bug 9760: Simplify local use preferences Removes a lot of code that was needed to handle prefs the old way. Test plan: Goto Local use preferences. Do you see some local preferences? Add a new pref, edit and delete it. Modify the url to systempreferences.pl?tab=OPAC or tab=log. You should only see a short message. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA comment: This patch removes a lot of useless code in the systempreferences.pl script. I didn't find anything to delete in the template file. All works great, no regression found. I will just remove the $sth->finish statements in my sign-off patch. Marked as Passed QA.
Created attachment 16037 [details] [review] Bug 9760: Simplify local use preferences Removes a lot of code that was needed to handle prefs the old way. Test plan: Goto Local use preferences. Do you see some local preferences? Add a new pref, edit and delete it. Modify the url to systempreferences.pl?tab=OPAC or tab=log. You should only see a short message. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Remove the $sth->finish statements
This patch has been pushed to master.