Bug 9766 - Remove YUI menu on budget planning page in favor of different column-hiding system
Summary: Remove YUI menu on budget planning page in favor of different column-hiding s...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL: /cgi-bin/koha/admin/aqplan.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-07 19:50 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9766 - Remove YUI menu on budget planning page in favor of different column-hiding system (15.86 KB, patch)
2013-03-08 13:35 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9766 - Remove YUI menu on budget planning page in favor of different column-hiding system (16.03 KB, patch)
2013-03-11 23:32 UTC, David Cook
Details | Diff | Splinter Review
Bug 9766 - Remove YUI menu on budget planning page in favor of different column-hiding system (16.05 KB, patch)
2013-04-01 14:53 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9766: [DRAFT] First try with colvis. (31.64 KB, patch)
2013-04-09 11:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9766 - Remove YUI menu on budget planning page in favor of different column-hiding system (16.04 KB, patch)
2013-04-24 12:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9766: [DRAFT] First try with colvis. (31.96 KB, patch)
2013-04-24 13:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9766 - Remove YUI menu on budget planning page in favor of different column-hiding system (16.06 KB, patch)
2013-04-24 14:41 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-03-07 19:50:56 UTC
There is a YUI menu on the budget planning page used to list columns in the table which can be hidden or shown. This menu should be replaced with a Bootstrap implementation.
Comment 1 Owen Leonard 2013-03-08 13:35:43 UTC Comment hidden (obsolete)
Comment 2 David Cook 2013-03-11 23:32:35 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-03-31 10:07:49 UTC
Owen, can you please rebase and switch back to signed off?
Comment 4 Owen Leonard 2013-04-01 14:53:35 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-04-03 12:41:45 UTC
Owen,

Did you have a look at ColVis (http://datatables.net/extras/colvis/)?
Maybe it could be useful to use it here, what do you think about it?
Comment 6 Jonathan Druart 2013-04-09 11:57:30 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2013-04-24 05:51:58 UTC
Owen, there is a merge conflict in your patch, could you please fix? And maybe give some feedback about the second?
I would like to see the YUI menus gone for 3.12.
Comment 8 Owen Leonard 2013-04-24 12:38:17 UTC Comment hidden (obsolete)
Comment 9 Owen Leonard 2013-04-24 12:42:15 UTC
(In reply to comment #7)
> maybe give some feedback about the second?

I haven't had a chance to test Jonathan's patch, and now it doesn't apply. I don't object to the idea of it, although I think it would be nice to keep this and the batch mod interfaces consistent with regard to showing and hiding columns.
Comment 10 Jonathan Druart 2013-04-24 13:12:06 UTC Comment hidden (obsolete)
Comment 11 Jonathan Druart 2013-04-24 13:12:36 UTC
(In reply to comment #9)
> I haven't had a chance to test Jonathan's patch, and now it doesn't apply. I
> don't object to the idea of it, although I think it would be nice to keep
> this and the batch mod interfaces consistent with regard to showing and
> hiding columns.

Rebased.
Owen, I really like to have your opinion on this DT plugin.
Not only for this patch (my goal is not to block this one), but more generally. We can imagine a configuration page for all tables in Koha (some users would like to display some columns, others want to hide them...).
Comment 12 Jonathan Druart 2013-04-24 14:40:42 UTC
QA comment:

Works great.
This patch gets rid of the last YUI menu in the intranet interface :)

Marked as Passed QA.
Comment 13 Jonathan Druart 2013-04-24 14:41:02 UTC
Created attachment 17655 [details] [review]
Bug 9766 - Remove YUI menu on budget planning page in favor of different column-hiding system

The budget planning table previously used a YUI menu as part of a
system for hiding and showing table columns. Instead of trying
to convert that sytem to Bootstrap I have used code from the
batch modification/deletion pages which uses a list of checkboxes
to show and hide table columns. This has the advantage of giving
the user visual feedback of what columns are hidden and of offering the
user an interface which is familiar from other pages.

This patch also moves CSS from a batch-operations-specific
CSS file into the main CSS file. Batch modification templates have been
modified accordingly.

To test, view the budget planning page and choose different
"plan by" options (by month, by library, by item type). Test
the show/hide action on each individual column and using the
"show all" and "hide all" checkboxes.

Signed-off-by: David Cook <dcook@prosentient.com.au>

Works as described.

This interface is also much more visually appealing, user-friendly, and informative than it was when it used the YUI menu.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 14 Jared Camins-Esakov 2013-04-26 01:57:14 UTC
This patch has been pushed to master and 3.12.x.