Bug 9768 - Problem with grace period calculation and fine intervals >1
Summary: Problem with grace period calculation and fine intervals >1
Status: RESOLVED DUPLICATE of bug 13590
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-08 10:59 UTC by Marcel de Rooy
Modified: 2015-10-23 13:06 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2013-03-08 10:59:50 UTC 
With a fine interval > 1 there is currently no way to avoid a effective grace period. Fines can not start the day after the due date.

Configuration:
With grace period = 1
fine interval 5 (= weekly, the library is closed Sunday and Saturday)

Result:
The first fine ist set 7 days after the item was due.
Monday, checkout
Tuesday, item due
Wednesday
Thursday
Friday
Saturday, holiday
Sunday, holiday
Monday,
Tuesday, first fine

Grace period for fine intervals > 1 should describe the days between the due date and the day the first fine is set.

CalcFines() in Overdues.pm:
 266         my $days_minus_grace = $daystocharge - $data->{'firstremind'};
 267     if ($data->{'chargeperiod'} > 0 && $days_minus_grace > 0 ) { 
 268         $amount = int($daystocharge / $data->{'chargeperiod'}) * $data->{'fine'};
Comment 1 Marcel de Rooy 2013-03-08 11:02:26 UTC 
Bug 4906 was originally meant for this problem, but went into another direction.
Hopefully, Katrin still wants to look at this..
Comment 2 Marcel de Rooy 2013-03-08 11:06:12 UTC 
QA Comment:
Kyle probably should have opened a new report for this development some time ago. I did now the other way around. Bug 9768 is the new old one :)

This patch works as advertised. Code looks good to me.

Passed QA
Comment 3 Marcel de Rooy 2013-03-08 11:06:53 UTC 
(In reply to comment #2)
> QA Comment:
> Kyle probably should have opened a new report for this development some time
> ago. I did now the other way around. Bug 9768 is the new old one :)
> 
> This patch works as advertised. Code looks good to me.
> 
> Passed QA

Yeah.. This should have been a comment at the other report..
Comment 4 Katrin Fischer 2014-12-12 22:46:06 UTC 
We are still very interested in seeing this fixed - until a new report is filed, I'd like to remove the WONTFIX.
Comment 5 Katrin Fischer 2015-10-23 13:06:03 UTC 
I am quite confident that bug 13590 fixes this.

*** This bug has been marked as a duplicate of bug 13590 ***