Bug 9774 - Search results shows "no holds allowed" for items "Waiting"
Summary: Search results shows "no holds allowed" for items "Waiting"
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-08 21:56 UTC by Jorge de Cardenas
Modified: 2020-01-06 20:15 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
No holds allowed in staff search results example (64.51 KB, image/png)
2013-10-18 18:36 UTC, HB-NEKLS
Details
Detail.pl holds are allowed example (131.92 KB, image/png)
2013-10-18 18:38 UTC, HB-NEKLS
Details
Request.pl holds allowed (42.74 KB, image/png)
2013-10-18 18:38 UTC, HB-NEKLS
Details
Catalog side no holds allowed example (122.94 KB, image/png)
2013-10-18 18:39 UTC, HB-NEKLS
Details
Holds allowed from search results example (51.17 KB, image/png)
2013-10-18 18:40 UTC, HB-NEKLS
Details
Detail.pl holds are allowed example (where also allowed in search results) (150.72 KB, image/png)
2013-10-18 18:41 UTC, HB-NEKLS
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jorge de Cardenas 2013-03-08 21:56:25 UTC
On the staff side search result, an item will show "No holds allowed" if the item is on hold "Waiting". See Search.pm line 1841.

if( $item ->{withdrawn}
|| $item->{itemlost}
...
|| $reservestatus eq 'Waiting' <====
|| ($transfertwhen ne ''))

One can still place holds on the item.
Comment 1 Nicole C. Engard 2013-09-11 11:37:59 UTC
Not sure this is an enhancement ... because a hold is allowed it's a bug.

Nicole
Comment 2 HB-NEKLS 2013-10-18 18:36:45 UTC
Created attachment 22070 [details]
No holds allowed in staff search results example
Comment 3 HB-NEKLS 2013-10-18 18:37:14 UTC
If there is only one item available to have a hold placed on it, and the item is waiting for pickup, no holds are allowed in search results, but can be placed on the detail.pl/reserves.pl pages. 

I can confirm this bug on 3.10.9 as well. 

I am attaching several screenshots examples of this situation. 

A particular record of 100 years of solitude has 1 item attached and is waiting for pickup. No holds are allowed from search results in both the staff and catalog sides of the system, but are allowed from the detail.pl and request.pl pages. 

A particular record of emerald green has 2 items attached. 1 item is waiting for pickup. 1 item is on order (but available for holds), and holds are allowed for search results.
Comment 4 HB-NEKLS 2013-10-18 18:38:02 UTC
Created attachment 22071 [details]
Detail.pl holds are allowed example
Comment 5 HB-NEKLS 2013-10-18 18:38:40 UTC
Created attachment 22072 [details]
Request.pl holds allowed
Comment 6 HB-NEKLS 2013-10-18 18:39:26 UTC
Created attachment 22073 [details]
Catalog side no holds allowed example
Comment 7 HB-NEKLS 2013-10-18 18:40:06 UTC
Created attachment 22074 [details]
Holds allowed from search results example
Comment 8 HB-NEKLS 2013-10-18 18:41:18 UTC
Created attachment 22075 [details]
Detail.pl holds are allowed example (where also allowed in search results)
Comment 9 Mickey Coalwell 2013-11-08 17:04:16 UTC
This appears to be a case where the message displayed in search.pl is erroneous, based on certain special cases. In addition to the cases documented by Heather, there appears to be another -- when there is a single item on the record, and it is IN TRANSIT. As Jorge noted in the original report, one CAN place holds on these items, regardless of the message displayed in search.pl.
Comment 10 HB-NEKLS 2014-03-04 16:03:10 UTC
In 3.14 this issue is no longer present.
Comment 11 Katrin Fischer 2019-04-28 10:29:01 UTC
(In reply to HB-NEKLS from comment #10)
> In 3.14 this issue is no longer present.

Marking FIXED, please file a new bug linked to this, if there is still a problem.