Bug 9781 - [3.6.X/3.8.x] Fix dynarch calendar positioning in IE
Summary: [3.6.X/3.8.x] Fix dynarch calendar positioning in IE
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low minor
Assignee: David Cook
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-10 23:44 UTC by David Cook
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 9781 - Fix bug in 3.8.x (dynarch) calendar positioning in IE (2.66 KB, patch)
2013-03-10 23:53 UTC, David Cook
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9781 - Fix bug in 3.8.x (dynarch) calendar positioning in IE (2.81 KB, patch)
2013-03-11 12:37 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2013-03-10 23:44:24 UTC
Currently, if you click on the calendar icon on a long patron entry/edit page, the calendar pop-up appears off-screen near the top of the page rather than under the appropriate input box next to the actual icon.

For most people, they don't think the calendar pop-up is actually created. For others, it's quite annoying to scroll up to the top of the page to pick a date for a date field lower on the page.
Comment 1 David Cook 2013-03-10 23:53:13 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-03-11 12:37:03 UTC
Created attachment 16024 [details] [review]
[SIGNED-OFF] Bug 9781 - Fix bug in 3.8.x (dynarch) calendar positioning in IE

Currently, if you click on the calendar icon on a long patron
entry/edit page, the calendar pop-up appears off-screen near the top of
the page rather than under the appropriate input box next to the actual
icon.

For most people, they don't think the calendar pop-up is actually
created. For others, it's quite annoying to scroll up to the top of the
page to pick a date for a date field lower on the page.

--

I've adapted a patch I found at the following URL:
http://blog.anorakgirl.co.uk/2009/04/dynarch-dhtml-calendar-ie7-positioning-problem/

This takes care of the problem.

--

Test Plan:

Before applying patch...

1) In any version of IE, create or edit a Patron entry
2) If you have a Date of birth field at the top, click the calendar icon
   next to it.
3) Note that the calendar pop-up appears fine.
4) Scroll down to the bottom of the page and click on the calendar icon
   next to Registration date or Expiry date.
5) Note that no calendar pop-up appears on the screen. Scroll up the
   page and you should see it up near the top of the page.

Apply patch

6) Refresh the page (you might need to clear your cache as well) and try
   clicking the calendar icon next to Registration date or Expiry date
7) Note that the calendar pop-up appears correctly underneath the input
   box for which you want to pick a date

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Tested successfully using IE9 on Windows 7.
Comment 3 Owen Leonard 2013-03-11 12:40:04 UTC
This bug affects 3.6.x too, and the patch applies there as well.
Comment 4 Marcel de Rooy 2013-03-29 13:37:57 UTC
QA Comment:
Looks good to me. Trivial change. Not tested :)
Sure that this comes up from IE7 onward ?

Changing status. Please attract the attention of 3.6.x/3.8.x RMaints yourself.
Thanks.
Comment 5 Marcel de Rooy 2013-03-29 13:39:11 UTC
Would not use staff client in IE BTW :)
Comment 6 Chris Cormack 2013-03-29 18:28:50 UTC
(In reply to comment #5)
> Would not use staff client in IE BTW :)

It's ok in IE9 onwards, but yeah, using the web with IE is just a bad idea :)
Comment 7 Chris Cormack 2013-03-29 18:30:22 UTC
Pushed to 3.8.x, over to you now Liz