The patch for Bug 8942 undid the changes to ajax.js made by Bug 9331.
Created attachment 16055 [details] [review] Bug 9797 - Untranslatable strings have returned to ajax.js The patch for Bug 8942 undid the changes to ajax.js made by Bug 9331. This patch puts those changes back. To test that preference-related error messages continue to work, open the system preferences editor in two tabs. Log out in one tab and try to save a system preference in the other. You should see correct error messages.
Created attachment 16275 [details] snapshot without patch
Created attachment 16278 [details] snapshot with patch
Hello Owen, sry but I need clarification, I join 2 snapshots, without the patch and with it. I see no differences, but probably I don't look at the right place. Could you precise the test plan ? Thx
Thanks for testing, The fact that you see no differences is a good sign the patch is working. The only way to test that the patch fixes translations is to update your translation and confirm that the string is now in the po file. For instance: Before the patch, searching misc/translator/po/fr-FR-i-staff-t-prog-v-3006000.po for the string "Error; your data might not have been saved" will return no results. After running "perl translate update fr-FR" from misc/translator another search should return one result for the same search.
Hello Owen, thx, unfortunately after the translate I have not the string in fr-FR-i-staff-t-prog-v-3006000.po. But we have two warnings during the translation (not due to your patch), I don't think it is related : Warning: Can't determine original templates' charset, defaulting to UTF-8 Warning: Charset Out defaulting to UTF-8 /home/christophe/workspace/versions/community/misc/translator/po/fr-FR-opac-ccsr.po: Aucun fichier ou dossier de ce type The first warning with utf8 by default I think it is ok, and the second one is about opac, so these warnings I think, are related with the fact that the translation doesn't insert the string expected. Maybe you have an idea about that. Thx
(In reply to comment #6) > Hello Owen, > thx, unfortunately after the translate I have not the string in > fr-FR-i-staff-t-prog-v-3006000.po. > But we have two warnings during the translation (not due to your patch) I get the same errors when I run "perl translate update fr-FR" (as I do in master), but I still see the new strings successfully added to the po file. Can you test again?
Created attachment 16747 [details] [review] Bug 9797 - Follow up : use double quotes in javascript translatable strings Followup to correct a translation bug, see Bug 8942
Created attachment 16752 [details] [review] [SIGNED-OFF] Bug 9797 - Untranslatable strings have returned to ajax.js Patch signed off by Pierre Angot
Created attachment 16753 [details] [review] [SIGNED-OFF] Bug 9797 - Follow up : use double quotes in javascript translatable strings Patch signed off by Pierre Angot
QA comment: These patches reintroduce changes made in bug 8942. Strings appears in po file. Marked as Passed QA.
Created attachment 16990 [details] [review] Bug 9797 - Untranslatable strings have returned to ajax.js The patch for Bug 8942 undid the changes to ajax.js made by Bug 9331. This patch puts those changes back. To test that preference-related error messages continue to work, open the system preferences editor in two tabs. Log out in one tab and try to save a system preference in the other. You should see correct error messages. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 16991 [details] [review] Bug 9797 - Follow up : use double quotes in javascript translatable strings Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.