Bug 9798 - Add html id to the Online Resources label of the OPAC detail page
Summary: Add html id to the Online Resources label of the OPAC detail page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: David Cook
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-12 02:39 UTC by David Cook
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9798 - Add html id to the Online Resources label of the OPAC detail page (1.47 KB, patch)
2013-03-12 02:47 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2013-03-12 02:39:42 UTC
We propose adding an id (onlineresources) to the Online Resources span on the OPAC detail page. 

I think the idea is to make the label easier to target with CSS and JScript.
Comment 1 David Cook 2013-03-12 02:47:08 UTC
Created attachment 16057 [details] [review]
Bug 9798 - Add html id to the Online Resources label of the OPAC detail page

This patch adds an id (onlineresources) to the Online Resources span on the OPAC detail page.

I think the idea is to make the label easier to target with CSS and JScript.

--

To Test:

Apply the patch

Create some code referencing the onlineresources id using the system preferences "intranetuserjs" or "intranetusercss". (e.g. #onlineresources {display:none;} or $("#onlineresources").text("Electronic Resources"); ).
Comment 2 Galen Charlton 2013-03-12 22:38:00 UTC
Comment on attachment 16057 [details] [review]
Bug 9798 - Add html id to the Online Resources label of the OPAC detail page

Review of attachment 16057 [details] [review]:
-----------------------------------------------------------------

::: koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt
@@ +710,4 @@
>      </span>[% END %]
>  
>      [% IF ( MARCURLS ) %]
> +    <div class="results_summary"><span class="label" id="onlineresources">Online resources:</span>

I suggest changing this to a CSS class called online_resources in the div, e.g.,

<div class="results_summary online_resources">

That way, it would be consistent with how the XSLT bib details display mode works.
Comment 3 Nicole C. Engard 2013-08-12 19:51:02 UTC
This seems to be done in master already.