Created attachment 16068 [details] locations label When in a single library the branches filter is replaced by locations - but if you have no shelving locations you still see the label for locations and shouldn't.
Facets are built in Search.pm, so I'm recategorizing this bug.
*** Bug 10479 has been marked as a duplicate of this bug. ***
Created attachment 19255 [details] [review] Bug 9801 - location facet shows even if no locations Test Plan: Before applying: 0) If you want to check the location facet (which is easiest), enable singlebranch mode in the globals system preferences. 1) Do a search for records/items that you have no shelving location specified (or simply remove the shelving location for a small range of records that you can find in a search query). 2) Note that "Location" appears amongst the facets even though there are no values/links present. (If you look at the HTML source, you'll see some empty HTML tags have been printed out.) Apply patch. 3) Flush your cache and refresh your page. 4) You should no longer see a "Location" facet (or those empty HTML tags) on the facet sidebar.
Created attachment 19462 [details] [review] [SIGNED OFF] Bug 9801 - location facet shows even if no locations Currently, the headings for facets (such as location) are showing even if there are no actual values/links for that facet type. This patch simply checks if the facet array contains any facets before printing the heading and HTML for each facet value/link. Test Plan: Before applying: 0) If you want to check the location facet (which is easiest), enable singlebranch mode in the globals system preferences. 1) Do a search for records/items that you have no shelving location specified (or simply remove the shelving location for a small range of records that you can find in a search query). 2) Note that "Location" appears amongst the facets even though there are no values/links present. (If you look at the HTML source, you'll see some empty HTML tags have been printed out.) Apply patch. 3) Flush your cache and refresh your page. 4) You should no longer see a "Location" facet (or those empty HTML tags) on the facet sidebar. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template changes only. Checked according to test plan, made sure location facet still shows up when values exist, otherwise it's hidden. It might make sense to add ids to the facets so libraries can decide to hide some of them easily. Or alternatively add a system preference to make that possible.
Created attachment 19610 [details] [review] Bug 9801 - location facet shows even if no locations Currently, the headings for facets (such as location) are showing even if there are no actual values/links for that facet type. This patch simply checks if the facet array contains any facets before printing the heading and HTML for each facet value/link. Test Plan: Before applying: 0) If you want to check the location facet (which is easiest), enable singlebranch mode in the globals system preferences. 1) Do a search for records/items that you have no shelving location specified (or simply remove the shelving location for a small range of records that you can find in a search query). 2) Note that "Location" appears amongst the facets even though there are no values/links present. (If you look at the HTML source, you'll see some empty HTML tags have been printed out.) Apply patch. 3) Flush your cache and refresh your page. 4) You should no longer see a "Location" facet (or those empty HTML tags) on the facet sidebar. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template changes only. Checked according to test plan, made sure location facet still shows up when values exist, otherwise it's hidden. It might make sense to add ids to the facets so libraries can decide to hide some of them easily. Or alternatively add a system preference to make that possible. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, David!
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks David!
Pushed to 3.10.x, will be in 3.10.11
Pushed to 3.8.x, will be in 3.8.18