This will add a test case that ensures that the .xml files in debian/docs are correctly formatted, just as a quick extra check that things are all happy.
Created attachment 16086 [details] [review] Bug 9802 - add test case to ensure man pages have correct XML To test: * run xt/verify-debian-docbook.t and make sure it's all OK * modify an xml file in debian/docs, try again, make sure it fails
Forgot to add to the commit message: this will also cause a package build failure if the XML is invalid.
Created attachment 16519 [details] [review] Bug 9802 - add test case to ensure man pages have correct XML To test: * run xt/verify-debian-docbook.t and make sure it's all OK * modify an xml file in debian/docs, try again, make sure it fails Signed-off-by: Magnus Enger <magnus@enger.priv.no> - Running "prove -v xt/verify-debian-docbook.t" loops through all the XML files in debian/docs and reports them as being ok. - Removing a "<" from one of the files makes the test report it as an error - I did not verify that the test actually trips up a package build if there is invalid XML.
Created attachment 16520 [details] [review] Bug 9802 - add test case to ensure man pages have correct XML To test: * run xt/verify-debian-docbook.t and make sure it's all OK * modify an xml file in debian/docs, try again, make sure it fails Signed-off-by: Magnus Enger <magnus@enger.priv.no> - Running "prove -v xt/verify-debian-docbook.t" loops through all the XML files in debian/docs and reports them as being ok. - Removing a "<" from one of the files makes the test report it as an error - I did not verify that the test actually trips up a package build if there is invalid XML.
Created attachment 16521 [details] [review] Bug 9802 - [SIGNED-OFF] add test case to ensure man pages have correct XML To test: * run xt/verify-debian-docbook.t and make sure it's all OK * modify an xml file in debian/docs, try again, make sure it fails Signed-off-by: Magnus Enger <magnus@enger.priv.no> - Running "prove -v xt/verify-debian-docbook.t" loops through all the XML files in debian/docs and reports them as being ok. - Removing a "<" from one of the files makes the test report it as an error - I did not verify that the test actually trips up a package build if there is invalid XML.
<magnuse> jcamins: i just signed off 9802 - i guess it does not need qa since it's from eythian and to do with the packages? <magnuse> bug 9802 <huginn> Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 enhancement, P5 - low, ---, robin, Signed Off , Add test case to verify package man pages are well formatted <jcamins> magnuse: yes, please set to Passed QA. :)
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12
Works nicely in master.