Bug 9802 - Add test case to verify package man pages are well formatted
Summary: Add test case to verify package man pages are well formatted
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Robin Sheat
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 8158
  Show dependency treegraph
 
Reported: 2013-03-12 23:12 UTC by Robin Sheat
Modified: 2013-12-05 20:06 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9802 - add test case to ensure man pages have correct XML (3.42 KB, patch)
2013-03-13 03:37 UTC, Robin Sheat
Details | Diff | Splinter Review
Bug 9802 - add test case to ensure man pages have correct XML (3.76 KB, patch)
2013-03-20 13:55 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 9802 - add test case to ensure man pages have correct XML (3.76 KB, patch)
2013-03-20 13:56 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 9802 - [SIGNED-OFF] add test case to ensure man pages have correct XML (3.76 KB, patch)
2013-03-20 13:57 UTC, Magnus Enger
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2013-03-12 23:12:32 UTC
This will add a test case that ensures that the .xml files in debian/docs are correctly formatted, just as a quick extra check that things are all happy.
Comment 1 Robin Sheat 2013-03-13 03:37:52 UTC Comment hidden (obsolete)
Comment 2 Robin Sheat 2013-03-13 03:39:11 UTC
Forgot to add to the commit message: this will also cause a package build failure if the XML is invalid.
Comment 3 Magnus Enger 2013-03-20 13:55:29 UTC Comment hidden (obsolete)
Comment 4 Magnus Enger 2013-03-20 13:56:01 UTC Comment hidden (obsolete)
Comment 5 Magnus Enger 2013-03-20 13:57:32 UTC
Created attachment 16521 [details] [review]
Bug 9802 - [SIGNED-OFF] add test case to ensure man pages have correct XML

To test:
* run xt/verify-debian-docbook.t and make sure it's all OK
* modify an xml file in debian/docs, try again, make sure it fails

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
- Running "prove -v xt/verify-debian-docbook.t" loops through all the
  XML files in debian/docs and reports them as being ok.
- Removing a "<" from one of the files makes the test report it as
  an error
- I did not verify that the test actually trips up a package build
  if there is invalid XML.
Comment 6 Magnus Enger 2013-03-20 14:01:50 UTC
<magnuse> jcamins: i just signed off 9802 - i guess it does not need qa since it's from eythian and to do with the packages? 
<magnuse> bug 9802
<huginn> Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9802 enhancement, P5 - low, ---, robin, Signed Off , Add test case to verify package man pages are well formatted
<jcamins> magnuse: yes, please set to Passed QA. :)
Comment 7 Jared Camins-Esakov 2013-03-20 19:11:35 UTC
This patch has been pushed to master.
Comment 8 Chris Cormack 2013-03-29 07:00:38 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.5 and 3.8.12
Comment 9 Magnus Enger 2013-04-25 08:04:51 UTC
Works nicely in master.