Created attachment 16104 [details] [review] Bug 9817 Add Goodreads reviews to OPAC To test 1/ Go to systempreferences and turn on goodreads reviews 2/ Search for a book in your opac, that is likely to be in Goodreads, and that has an isbn 3/ Look in the opac detail page for a good reads review tab Should work in both prog and ccsr
Created attachment 16119 [details] [review] Bug 9817 Add Goodreads reviews to OPAC To test 1/ Go to systempreferences and turn on goodreads reviews 2/ Search for a book in your opac, that is likely to be in Goodreads, and that has an isbn 3/ Look in the opac detail page for a good reads review tab Should work in both prog and ccsr Signed-off-by: Liz Rea <liz@catalyst.net.nz> Very lovely! Note: fixed a paste error in the database update description.
Thanks for the sign off Liz, but since we now both are Catalystas, I'll leave it needs signoff for an outside signoff. Hint, it should be easy to signoff Liz already tested it!, and fixed a paste error.
gr forgot to change it to my personal email, lol. Dangit.
Wouldn't actually have mattered, I did the work under my personal email, not catalysts, I'd still prefer another sign off :)
Created attachment 16442 [details] [review] Bug 9817 Add Goodreads reviews to OPAC To test 1/ Go to systempreferences and turn on goodreads reviews 2/ Search for a book in your opac, that is likely to be in Goodreads, and that has an isbn 3/ Look in the opac detail page for a good reads review tab Should work in both prog and ccsr Signed-off-by: Liz Rea <liz@catalyst.net.nz> Very lovely! Note: fixed a paste error in the database update description. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Tested both themes, looks alright
Works as expected. I fixed the usual database related merge conflicts (installer/data/mysql/sysprefs.sql + installer/data/mysql/updatedatabase.pl)
I talked to Chris and we agreed that this is not quite ready yet.
Created attachment 16826 [details] [review] Bug 9817 Add Goodreads reviews to OPAC To test 1/ Go to systempreferences and turn on goodreads reviews 2/ Search for a book in your opac, that is likely to be in Goodreads, and that has an isbn 3/ Look in the opac detail page for a good reads review tab Should work in both prog and ccsr Signed-off-by: Liz Rea <liz@catalyst.net.nz> Very lovely! Note: fixed a paste error in the database update description. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Tested both themes, looks alright
QA comment: Works great. There is a h1 title (Goodreads reviews for) even if there are no reviews. But I don't know how avoid that. Is it normal that the syspref GoodReadsKey is not added to the systempreferences table (in sysprefs.sql and updatedatabase.pl)? I wait explanation about the missing pref before passing QA.
It's not actually used for anything yet, the reviews don't need a key. It's there mainly in prep for more good reads work. So we could remove it. I kinda lost interest in goodreads when amazon bought them.
I think as Chris is not planning to do more work on Goodreads it would be good to remove the system preference so there is no confusion on how to use this feature.
Would love to see this feature. Interested in the GoodReads content enhancing Koha. Christopher
+1. More of our patrons use Goodreads than the other social reading platforms, so it would be a bigger selling point than Library Thing or the others that are already baked in.
Please note that this bug is 'closed wontfix' - so currently noone is working on this or intending to.
(In reply to Katrin Fischer from comment #15) > Please note that this bug is 'closed wontfix' - so currently noone is > working on this or intending to. Yes, but I am generating conversation in hopes that it will be pursued again.
Just an FYI as the original author, I won't be working on advertising Amazon for free. So working on raising money to pay a dev might be a better avenue ;)