'insecure' system preference must be removed. Functionality enabled by this system preference is broken. In case that is set to Allow, staff login is not possible any more. Related to Bug 9562
Created attachment 16175 [details] [review] Bug 9827: remove 'insecure' system preference This patch removes 'insecure' system preference. Also removes remaining code that make use of the preference. It's broken anyway. Only remains a reference in POD of C4/Boolean.pm To test: 1) If you like, enable 'insecure' syspref. Broken system. WARN: be prepared to revert value in database. 2) Apply the patch 3) Run updatedatabase.pl 4) Check that Staff login proceeds as usual. 5) Check that 'insecure' syspref is no more.
Created attachment 16177 [details] [review] Bug 9827: remove 'insecure' system preference This patch removes 'insecure' system preference. Also removes remaining code that make use of the preference. It's broken anyway. Only remains a reference in POD of C4/Boolean.pm To test: 1) If you like, enable 'insecure' syspref. Broken system. WARN: be prepared to revert value in database. 2) Apply the patch 3) Run updatedatabase.pl 4) Check that Staff login proceeds as usual. 5) Check that 'insecure' syspref is no more. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
QA comment: This patch removes the insecure syspref. The 'insecure' behavior is not well implemented and some scripts raise an error if enabled. Marked as Passed QA.
Created attachment 16211 [details] [review] Bug 9827: remove 'insecure' system preference This patch removes 'insecure' system preference. Also removes remaining code that make use of the preference. It's broken anyway. Only remains a reference in POD of C4/Boolean.pm To test: 1) If you like, enable 'insecure' syspref. Broken system. WARN: be prepared to revert value in database. 2) Apply the patch 3) Run updatedatabase.pl 4) Check that Staff login proceeds as usual. 5) Check that 'insecure' syspref is no more. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Amended patch: Remove 2 occurrences of insecure (in comment only)
This patch has been pushed to master.