[MT10401] When running the SIP tests, 04patron_status.t returns errors because some patron informations are hard coded instead of using the variables defined in SIPtest.pm TEST PLAN : 1) In "C4/SIP/t", configure the SIPtest.pm file. 2) Configure your SIPconfig.xml if needed. 3) Start your SIP server. 4) In "C4/SIP/t", do a "make test" (see the README file for more informations) (some others tests give errors too, I'll create separate patches for that)
Created attachment 16291 [details] [review] proposed patch #1
Created attachment 16389 [details] [review] Bug 9838: fix on 04patron_status.t Some patron infos were hard coded instead of using the variables defined in SIPtest.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA comment: I can't launch tests for SIP but this patch looks good. Marked as Passed QA.
Created attachment 17119 [details] [review] Bug 9838: fix on 04patron_status.t Some patron infos were hard coded instead of using the variables defined in SIPtest.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.
Pushed to 3.8.x and 3.10.x will be in 3.8.12 and 3.10.5