Created attachment 16308 [details] screenshot of no items added with item processing set to always add In 3.10.3, I am importing staged MARC records from Tools with these settings. Matching rule: ISBN (020$a) Action if matching record found: Ignore incoming record (its items may still be processed) Action if no match found: Ignore incoming record (its items may still be processed) Item processing: Always add items When I import a matching record, zero items are added. (See attached screenshot.) I expected the items to be processed anyway. Is this a bug? If I change "Action if matching record found" to something other than "Ignore," then an item record is created in that case.
Created attachment 16948 [details] [review] Bug 9839 - when importing MARC records, item record not created even when set to "always add" Test Plan: 1) Catalog a new record with an ISBN 2) Add some items to the record 3) Download the record as MARCXML 4) Delete the itemnumbers from the 952 fields in the record, Change the barcode fields to unused barcodes 5) Use xml2marc to save as a standard MARC file 6) Import the record using the 'Stage MARC for import' tool Use the settings: Record matching rule: ISBN Action if matching record found: ignore Action if no match found: ignore Item processing: always_add Check for embedded item record data?: Yes How to process items: Always add items 7) Import, note the bib is ignored, and the items are not processed 8) Undo import into catalog 8) Apply this patch 9) Import this batch into the catalog 10) Note the items were processed and are now added to the matching record
I'm sure there are other ways to test this, but this is the method I used.
I tested with unimarc record, following your test plan (except the items are stored in 995 and not in 952). It works well. This issue was very annoying for us! Thank you Kyle. Mathieu Saby Rennes 2 University
Created attachment 16952 [details] [review] [PATCH][SIGNED OFF] Bug 9839 - when importing MARC records, item record not created even when set to "always add"
I confirm the bug, ad the solution.
Created attachment 17439 [details] [review] Bug 9839 - when importing MARC records, item record not created even when set to "always add" Test Plan: 1) Catalog a new record with an ISBN 2) Add some items to the record 3) Download the record as MARCXML 4) Delete the itemnumbers from the 952 fields in the record, Change the barcode fields to unused barcodes 5) Use xml2marc to save as a standard MARC file 6) Import the record using the 'Stage MARC for import' tool Use the settings: Record matching rule: ISBN Action if matching record found: ignore Action if no match found: ignore Item processing: always_add Check for embedded item record data?: Yes How to process items: Always add items 7) Import, note the bib is ignored, and the items are not processed 8) Undo import into catalog 8) Apply this patch 9) Import this batch into the catalog 10) Note the items were processed and are now added to the matching record Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Tested with UNIMARC record. I followed the test plan, just changing 952 by 995 Signed-off-by: Mason James <mtj@kohaaloha.com>
(In reply to comment #6) > Created attachment 17439 [details] [review] [review] > Bug 9839 - when importing MARC records, item record not created even when > set to "always add" > Signed-off-by: Mason James <mtj@kohaaloha.com> patch looks good - passing QA on this patch...
> patch looks good - passing QA on this patch... fyi: this bug should probably have its version updated from '3.10' to 'master'
Updating version as Mason suggested.
This patch has been pushed to master and 3.12.x.
Pushed to 3.10.x will be in 3.10.6