Time for the standing ticket for the help file updates - patches will start coming soon.
Created attachment 16851 [details] [review] Bug 9850: Update Stray Help Files This patch updates the help files which do not have a module folder. To test: Visit About Koha, Koha Home, and the No Help Found pages and check links to the manual.
Created attachment 16852 [details] [review] Bug 9850: Update Authority Help Files This patch just updates the links to the manual in the Authority help files. To Test: Visit the help on all authority pages and click the manual link in the help pop up. It should go to the 3.12 manual.
Created attachment 16854 [details] [review] Bug 9850: Update Label Help Files This patch updates the manual links in the label creator help files. There were not other string changes. To test: Visit the help on the label creator and make sure that the links go to the 3.12 manual.
Created attachment 16856 [details] [review] Bug 9850: Update Patron Card Help Files This patch updates the links to the manual in the patron card creator help files. There were no other changes. To test: Visit help on the patron card creator tool and make sure the links are right.
Created attachment 16890 [details] [review] Bug 9850: Update Patron Help Files for 3.12 This patch updates all the help files in the members folder. It also adds a missing help file for approving patron account changes. To Test: Visit the help on every patron page and make sure the text and manual links are all right.
Created attachment 16899 [details] [review] Bug 9850: Update Admin Help Files for 3.12 This patch updates the links to the manual and the text of the admin help files. To test: Visit the help files on all admin pages and make sure the links and text are right.
Created attachment 16947 [details] [review] Bug 9850: Acq Help Files for 3.12 This patch updates the manual links and some text in the acq help files. To test: Visit help on all acq pages and make sure links and text are right.
Created attachment 16949 [details] [review] Bug 9850: Catalogue help files This patch updates the help files in the catalogue folder. To test: Visit the help on the search, detail pages, item details and item history pages and confirm text and links are right.
Created attachment 16950 [details] [review] Bug 9850: Put manual link in an include This patch just adds a new include file that will be used in all future help file updates to link to the current manual. To test: Just make sure there is a new file in the includes folder.
Comment on attachment 16950 [details] [review] Bug 9850: Put manual link in an include Wrong idea
Created attachment 16951 [details] [review] Bug 9850: Add include with manual link This patch adds a link to the Koha manual so that it can be included easily on all help files and updated once with new releases. It can also be updated to point to other languages of the manual if you so choose. To test: Just make sure there is a new file - future help file patches will use this include for generating manual links.
Created attachment 16958 [details] [review] [ALTERNATIVE] Bug 9850: Build the version for the manual link Robin launched a discussion on koha-devel about this bug. I create a little patch for building the version in the pl file. On this way, templates will no longer be changed for each version. For discussion.
We talked about this on IRC yesterday and decided to worry about that with the next release since we're so close to release right now and I need to get this done. There is more than the version to think about - there is the language as well. And when the version is a dev version we need to link to the next manual - which may or may not be ready yet. There is too much to discuss right now and I need to get this done this week due to my work schedule. Also - I need to review every help file anyway to see if there are differences that need to be added - so updating the link takes me no time at all.
Created attachment 16974 [details] [review] Bug 9850: Update Tags & Comments Help This patch updates the text and links for the Tag and Comment moderation tools. To test: Visit the help on the tags and comments tools and confirm that text and links are right.
Created attachment 16975 [details] [review] Bug 9850: Add missing tags help file This patch adds a help file to the listing of titles that use a tag in the tag moderation tool. To test: * Visit the Tag Moderation Tool * Click on a accepted tag * Check that the help file loads on the list and that the text and links are right.
Created attachment 16980 [details] [review] Bug 9850: Update holds help file This updates the manual link on the holds help file. To test: Visit the holds tab on any bib record and click the Help link. Make sure it goes to the right place.
Created attachment 16981 [details] [review] Bug 9850: Update Lists Help This updates the manual link in the lists help file. To test: Visit lists pages in the staff client, view the help and confirm link goes to the right place.
Created attachment 16999 [details] [review] Bug 9850: Update Stray Help Files This patch updates the help files which do not have a module folder. To test: Visit About Koha, Koha Home, and the No Help Found pages and check links to the manual. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17000 [details] [review] Bug 9850: Update Authority Help Files This patch just updates the links to the manual in the Authority help files. To Test: Visit the help on all authority pages and click the manual link in the help pop up. It should go to the 3.12 manual. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17001 [details] [review] Bug 9850: Update Label Help Files This patch updates the manual links in the label creator help files. There were not other string changes. To test: Visit the help on the label creator and make sure that the links go to the 3.12 manual. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17002 [details] [review] Bug 9850: Update Patron Card Help Files This patch updates the links to the manual in the patron card creator help files. There were no other changes. To test: Visit help on the patron card creator tool and make sure the links are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17003 [details] [review] Bug 9850: Update Patron Help Files for 3.12 This patch updates all the help files in the members folder. It also adds a missing help file for approving patron account changes. To Test: Visit the help on every patron page and make sure the text and manual links are all right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17004 [details] [review] Bug 9850: Update Admin Help Files for 3.12 This patch updates the links to the manual and the text of the admin help files. To test: Visit the help files on all admin pages and make sure the links and text are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17005 [details] [review] Bug 9850: Acq Help Files for 3.12 This patch updates the manual links and some text in the acq help files. To test: Visit help on all acq pages and make sure links and text are right.
Created attachment 17006 [details] [review] Bug 9850: Acq Help Files for 3.12 This patch updates the manual links and some text in the acq help files. To test: Visit help on all acq pages and make sure links and text are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17007 [details] [review] Bug 9850: Catalogue help files This patch updates the help files in the catalogue folder. To test: Visit the help on the search, detail pages, item details and item history pages and confirm text and links are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17008 [details] [review] Bug 9850: Build the version for the manual link Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I like this idea, it is a much nicer way of doing it, I'll leave it to the QA and RM to decide
Created attachment 17009 [details] [review] Bug 9850: Update Tags & Comments Help This patch updates the text and links for the Tag and Comment moderation tools. To test: Visit the help on the tags and comments tools and confirm that text and links are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17010 [details] [review] Bug 9850: Add missing tags help file This patch adds a help file to the listing of titles that use a tag in the tag moderation tool. To test: * Visit the Tag Moderation Tool * Click on a accepted tag * Check that the help file loads on the list and that the text and links are right.
Created attachment 17011 [details] [review] Bug 9850: Update holds help file This updates the manual link on the holds help file. To test: Visit the holds tab on any bib record and click the Help link. Make sure it goes to the right place.
Created attachment 17012 [details] [review] Bug 9850: Update holds help file This updates the manual link on the holds help file. To test: Visit the holds tab on any bib record and click the Help link. Make sure it goes to the right place. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17013 [details] [review] Bug 9850: Update Lists Help This updates the manual link in the lists help file. To test: Visit lists pages in the staff client, view the help and confirm link goes to the right place. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17025 [details] [review] Bug 9850: Reports Help for 3.12 This updates the reports help for Koha 3.12. To test: Visit all reports pages and review the help for textual changes and correct links.
I've visited all reports pages and review the help for textual changes It seems to be OK There is 1 incorrect link. from Statistics wizards, in the Holds statistics help page, the link to the online manual is wrong : (it's a link to the sandbox) http://pro.test1.biblibre.com/cgi-bin/koha/manual.koha-community.org/3.12/en/statsreports.html#holdstats
Created attachment 17094 [details] [review] Bug 9850: Cataloging Help for 3.12 This updates just the links in the cataloging help, no text changes where made. To test: Visit help in cataloging and click the manual links and make sure they're right.
Created attachment 17095 [details] [review] Bug 9850: Update Reports Help for 3.12 This updates the reports help for Koha 3.12. To test: Visit all reports pages and review the help for textual changes and correct links.
Reports Help file has been updated to fix the broken link! Thanks for finding that. Nicole
Created attachment 17096 [details] [review] Bug 9850: Serial Help Files for 3.12 Update text and links for Serials help files. To test: Visit all serial related pages and check the text of the help and test the links.
Created attachment 17097 [details] [review] Bug 9850: Suggestion Help File for 3.12 This updates the text and link on the suggestions help file. To test: Visit the manage suggestions page and review the help file.
Created attachment 17098 [details] [review] Bug 9850: Offline Circ Help Files for 3.12 This updates the text and links in the offline circulation tool help files. To test: Visit all offline circulation pages in the staff client and review the text and links.
Created attachment 17102 [details] [review] Bug 9850: Update Circ Help for 3.12 This updates the text and links for the Circulation Help Files. It also removes an unused help file 'billing.tt'. To test: Visit the help files on all circ pages and confirm links and text are right.
Created attachment 17103 [details] [review] Bug 9850: Update Circ Help Files for 3.12 This updates the text and links for the Circulation Help Files. It also removes an unused help file 'billing.tt'. To test: Visit the help files on all circ pages and confirm links and text are right.
Created attachment 17104 [details] [review] Bug 9850: Add Plugin Help File for 3.12 This adds a help file to the new plugins module. To test: Activate the plugin module and check the text and links in the help file
Created attachment 17105 [details] [review] Bug 9850: Update Tools Help for 3.12 Update the text and links in the Tools help files. To test: Check the text and links on all help files under Tools.
I believe that I am done - 1/2 of these are signed off and 1/2 need sign off. Nicole
Created attachment 17122 [details] [review] Bug 9850: FOLLOW UP: Add Missing Plugin Help for 3.12 This patch is a follow up to the one that adds the plugin help. To test: Visit the upload a plugin page and review the help and links.
Created attachment 17139 [details] [review] [SIGNED-OFF] Bug 9850: Cataloging Help for 3.12 This updates just the links in the cataloging help, no text changes where made. To test: Visit help in cataloging and click the manual links and make sure they're right. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 17140 [details] [review] [SIGNED-OFF] Bug 9850: Update Reports Help for 3.12 This updates the reports help for Koha 3.12. To test: Visit all reports pages and review the help for textual changes and correct links. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 17141 [details] [review] [SIGNED-OFF] Bug 9850: Serial Help Files for 3.12 Update text and links for Serials help files. To test: Visit all serial related pages and check the text of the help and test the links. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 17142 [details] [review] [SIGNED-OFF] Bug 9850: Suggestion Help File for 3.12 This updates the text and link on the suggestions help file. To test: Visit the manage suggestions page and review the help file. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 17143 [details] [review] [SIGNED-OFF] Bug 9850: Offline Circ Help Files for 3.12 This updates the text and links in the offline circulation tool help files. To test: Visit all offline circulation pages in the staff client and review the text and links. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 17144 [details] [review] [SIGNED-OFF] Bug 9850: Update Circ Help Files for 3.12 This updates the text and links for the Circulation Help Files. It also removes an unused help file 'billing.tt'. To test: Visit the help files on all circ pages and confirm links and text are right. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 17145 [details] [review] [SIGNED-OFF] Bug 9850: Add Plugin Help File for 3.12 This adds a help file to the new plugins module. To test: Activate the plugin module and check the text and links in the help file Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 17146 [details] [review] [SIGNED-OFF] Bug 9850: Update Tools Help for 3.12 Update the text and links in the Tools help files. To test: Check the text and links on all help files under Tools. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I fixed one instance of a link to 3.10 instead of 3.12.
Created attachment 17147 [details] [review] [SIGNED-OFF] Bug 9850: FOLLOW UP: Add Missing Plugin Help for 3.12 This patch is a follow up to the one that adds the plugin help. To test: Visit the upload a plugin page and review the help and links. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 17193 [details] [review] [PASSED QA] Bug 9850: Cataloging Help for 3.12 This updates just the links in the cataloging help, no text changes where made. To test: Visit help in cataloging and click the manual links and make sure they're right. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17194 [details] [review] [PASSED QA] Bug 9850: Update Reports Help for 3.12 This updates the reports help for Koha 3.12. To test: Visit all reports pages and review the help for textual changes and correct links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17195 [details] [review] [PASSED QA] Bug 9850: Serial Help Files for 3.12 Update text and links for Serials help files. To test: Visit all serial related pages and check the text of the help and test the links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17196 [details] [review] [PASSED QA] Bug 9850: Suggestion Help File for 3.12 This updates the text and link on the suggestions help file. To test: Visit the manage suggestions page and review the help file. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17197 [details] [review] [PASSED QA] Bug 9850: Offline Circ Help Files for 3.12 This updates the text and links in the offline circulation tool help files. To test: Visit all offline circulation pages in the staff client and review the text and links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17198 [details] [review] [PASSED QA] Bug 9850: Update Circ Help Files for 3.12 This updates the text and links for the Circulation Help Files. It also removes an unused help file 'billing.tt'. To test: Visit the help files on all circ pages and confirm links and text are right. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17199 [details] [review] [PASSED QA] Bug 9850: Add Plugin Help File for 3.12 This adds a help file to the new plugins module. To test: Activate the plugin module and check the text and links in the help file Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17200 [details] [review] [PASSED QA] Bug 9850: Update Tools Help for 3.12 Update the text and links in the Tools help files. To test: Check the text and links on all help files under Tools. Signed-off-by: Owen Leonard <oleonard@myacpl.org> I fixed one instance of a link to 3.10 instead of 3.12. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17201 [details] [review] [PASSED QA] Bug 9850: FOLLOW UP: Add Missing Plugin Help for 3.12 This patch is a follow up to the one that adds the plugin help. To test: Visit the upload a plugin page and review the help and links. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
The first batch of patches has been pushed to master and 3.12.x.
All of the patches attached by Chris are signed off patches. They were skipped during QA and Pushing. Nicole
Comment on the help version calculation: +my $help_version = C4::Context->preference("Version"); +if ( $help_version =~ m|^(\d+)\.(\d{2}).*$| ) { + my $version = $1; + my $major = $2; + if ( $major % 2 ) { $major-- }; + $help_version = "$version.$major"; +} +$template->param( helpVersion => $help_version ); I am testing this now. We are still in 3.11, but I should have seen 3.12, but I just see 3.10. Please find some extra test to make the decision to go to 3.12. Perhaps something with the last digits? Now we are e.g. at 200. If we are testing alpha or beta versions, the help version should go up somehow..
Comment on attachment 17008 [details] [review] Bug 9850: Build the version for the manual link Marking obsolete so that the other help patches don't suffer. The others are all text and should be QA'd before 3.12 released. We can address this issue in a later version. Maybe even another bug report.
Comment on attachment 17003 [details] [review] Bug 9850: Update Patron Help Files for 3.12 Review of attachment 17003 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/help/members/member-flags.tt @@ +10,1 @@ > There is a bit of a mix between old and new capitalization in this file: <h2>Patron permissions</h2> <p>Patron Permissions are used to allow staff members access to the staff client.</p> <h3>Setting Patron Permissions</h3> @@ +43,5 @@ > </ul> > </li> > <li>parameters > <ul> > + <li>Manage Koha system systems (Administration panel)</li> This doesn't look right. @@ +465,5 @@ > </ul> > </li> > <li>execute_reports > <ul> > + <li>Execure SQL Reports</li> Little typo.
Created attachment 17629 [details] [review] [PASSED QA] Bug 9850: Update Stray Help Files This patch updates the help files which do not have a module folder. To test: Visit About Koha, Koha Home, and the No Help Found pages and check links to the manual. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Updating links to new version.
Created attachment 17630 [details] [review] [PASSED QA] Bug 9850: Update Authority Help Files This patch just updates the links to the manual in the Authority help files. To Test: Visit the help on all authority pages and click the manual link in the help pop up. It should go to the 3.12 manual. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Updating links to new version.
Created attachment 17631 [details] [review] [PASSED QA] Bug 9850: Update Label Help Files This patch updates the manual links in the label creator help files. There were not other string changes. To test: Visit the help on the label creator and make sure that the links go to the 3.12 manual. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Updating links.
Created attachment 17632 [details] [review] [PASSED QA] Bug 9850: Update Patron Card Help Files This patch updates the links to the manual in the patron card creator help files. There were no other changes. To test: Visit help on the patron card creator tool and make sure the links are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17633 [details] [review] [PASSED QA] Bug 9850: Update Patron Help Files for 3.12 This patch updates all the help files in the members folder. It also adds a missing help file for approving patron account changes. To Test: Visit the help on every patron page and make sure the text and manual links are all right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixed 2 obvious typos mentioned on the bug report.
Created attachment 17634 [details] [review] [PASSED QA] Bug 9850: Update Admin Help Files for 3.12 This patch updates the links to the manual and the text of the admin help files. To test: Visit the help files on all admin pages and make sure the links and text are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17635 [details] [review] [PASSED QA] Bug 9850: Acq Help Files for 3.12 This patch updates the manual links and some text in the acq help files. To test: Visit help on all acq pages and make sure links and text are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17636 [details] [review] [PASSED QA] Bug 9850: Catalogue help files This patch updates the help files in the catalogue folder. To test: Visit the help on the search, detail pages, item details and item history pages and confirm text and links are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17637 [details] [review] [PASSED QA] Bug 9850: Update Tags & Comments Help This patch updates the text and links for the Tag and Comment moderation tools. To test: Visit the help on the tags and comments tools and confirm that text and links are right. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17638 [details] [review] [PASSED QA] Bug 9850: Add missing tags help file This patch adds a help file to the listing of titles that use a tag in the tag moderation tool. To test: * Visit the Tag Moderation Tool * Click on a accepted tag * Check that the help file loads on the list and that the text and links are right. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17639 [details] [review] [PASSED QA] Bug 9850: Update holds help file This updates the manual link on the holds help file. To test: Visit the holds tab on any bib record and click the Help link. Make sure it goes to the right place. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 17640 [details] [review] [PASSED QA] Bug 9850: Update Lists Help This updates the manual link in the lists help file. To test: Visit lists pages in the staff client, view the help and confirm link goes to the right place. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This patch has been pushed to master and 3.12.x.