The Did you mean? from authorities creates links that use = rather than : for indexes.
For example: - Turn on the AuthorityFile plugin for the OPAC in the "Did you mean" section of the administration module - Search a term in your OPAC where some authorities exist for it - like a name or a place. My example search is: Deutschland or Germany - Verify that there are suggestions displayed on top of the result list - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084
Created attachment 45398 [details] [review] Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084
Created attachment 45490 [details] [review] Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084 Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Created attachment 45505 [details] [review] Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084 Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Hi all I did a search of this type su:country music the search result still presented with /cgi-bin/koha/opac-search.pl?q=su-na=country music I think IMHO this needs a follow-up Regards
Can someone verify/dispute Héctor's comment?
Created attachment 66218 [details] [review] Bug 9857 - Follow-up - Fix for searches with su= or su: When the initial search is su=.../su:... the links was not constructed correctly. With this change, it should be the case.
Follow-up posted - back to Needs Sign-off.
Created attachment 66325 [details] [review] [SIGNED-OFF] Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084 Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 66326 [details] [review] [SIGNED-OFF] Bug 9857 - Follow-up - Fix for searches with su= or su: When the initial search is su=.../su:... the links was not constructed correctly. With this change, it should be the case. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 66717 [details] [review] Bug 9857: Did you mean? uses wrong punctuation in search links The link changes the search links generated by the plugins from an=authid to an:authid, as suggested by Jared on the bug report. - Turn on the AuthorityFile und ExplodedTerms plugins for the OPAC from the "Did you mean" section of the administration module - Search a term in your OPAC where one or several authorities exist. A last name or a place name might work well. - Verify that there are suggestions displayed on top of your result list. - Verify that the link created is something like: /cgi-bin/koha/opac-search.pl?q=an=14084 - Apply patch. - Verify the link has changed a little and still works correctly: /cgi-bin/koha/opac-search.pl?q=an:14084 Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 66718 [details] [review] Bug 9857 - Follow-up - Fix for searches with su= or su: When the initial search is su=.../su:... the links was not constructed correctly. With this change, it should be the case. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master for 17.11, thanks to everybody involved!
Created attachment 66780 [details] [review] Bug 9857: Fix failing test Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 66781 [details] [review] Bug 9857: Fix failing tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(In reply to Jonathan Druart from comment #15) > Created attachment 66781 [details] [review] [review] > Bug 9857: Fix failing tests > > Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Patch pushed to master!
Pushed to 17.05.x, will be in 17.05.05.
These patches have been pushed to 16.11.x and will be in 16.11.13.
Pushed to 16.05.x, for 16.05.18 release