Bug 9860 - Incorrect box heading 'Cannot check in' when a late document is returned
Summary: Incorrect box heading 'Cannot check in' when a late document is returned
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P4 normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-20 09:14 UTC by Koha Team University Lyon 3
Modified: 2014-05-26 21:04 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
cannot check in (9.05 KB, image/png)
2013-03-20 09:14 UTC, Koha Team University Lyon 3
Details
Bug 9860 Incorrect box heading (Cannot check in) when a document is late (1.17 KB, patch)
2013-04-08 09:00 UTC, Koha Team University Lyon 3
Details | Diff | Splinter Review
Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document is returned (2.27 KB, patch)
2013-04-08 14:37 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document is returned (2.29 KB, patch)
2013-04-09 09:06 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document is returned (2.35 KB, patch)
2013-04-19 14:31 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Koha Team University Lyon 3 2013-03-20 09:14:01 UTC
Created attachment 16458 [details]
cannot check in

When a late document is checked in, every thing works as it should (the check in is correctly recorded) except that the warning box displays, in addition to the usual restriction applied to patron, an extra and inappropriate heading 'Cannot check in'. (cf joined image).
Comment 1 Koha Team University Lyon 3 2013-04-08 09:00:42 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-04-08 14:06:40 UTC
In order to understand the problem that needs to be fixed here we have to look at the cause: Bug 9397. The patch for that bug made the incorrect assumption that for all check-in error messages the appropriate message is "Cannot check in." As this bug shows, this is not correct. In fact the way the template was before Bug 9397 is more correct.

A correct fix which covered the goals of both bugs would revert the changes made by bug 9397 and add a generic heading for all check-in messages. "Check in notice" or something vague like that.
Comment 3 Owen Leonard 2013-04-08 14:37:09 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2013-04-09 09:06:37 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-04-19 14:30:49 UTC
QA comment:

My fault, I amended the patch for bug 9397 too quickly!

This one is a string patch and fix correctly the message problem.

Marked as Passed QA.
Comment 6 Jonathan Druart 2013-04-19 14:31:01 UTC
Created attachment 17555 [details] [review]
Bug 9860 [Alternate] Incorrect box heading 'Cannot check in' when a late document is returned

The fix for Bug 9397 moved the "cannot check in" heading from within the
one conditional where it should have been displayed to the top of all
check-in errors/messages. "Cannot check in" is still only valid if the
item is withdrawn and BlockReturnOfWithdrawnItems is ON.

In order to accomplish the goal of Bug 9397 while fixing Bug 9860 this
patch puts "cannot check in" back into the correct conditional and adds
a generic heading to check in messages for accessibility purposes.

To test, check in items which will trigger a variety of errors
including:

- item must be returned to home library
- item is lost
- item is withdrawn (wtih BlockReturnOfWithdrawnItems on and off)
- item is overdue

...as well as items which should check in normally. Messages should
display correctly.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Jared Camins-Esakov 2013-04-21 13:34:21 UTC
This patch has been pushed to master and 3.12.x.
Comment 8 Chris Cormack 2013-04-27 05:37:29 UTC
Pushed to 3.10.x will be in 3.10.6