Bug 9877 - Use DataTables on funds administration page
Summary: Use DataTables on funds administration page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL: /cgi-bin/koha/admin/aqbudgets.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-20 19:16 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9877 - Use DataTables on funds administration page (2.97 KB, patch)
2013-03-20 19:25 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9877 - Use DataTables on funds administration page (2.99 KB, patch)
2013-03-21 08:54 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 9877 - Use DataTables on funds administration page (2.99 KB, patch)
2013-03-21 09:11 UTC, Paul Poulain
Details | Diff | Splinter Review
Bug 5342: Followup Delete tags for letters which are not html (844 bytes, patch)
2013-03-21 09:13 UTC, Paul Poulain
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9877 - Use DataTables on funds administration page (3.52 KB, patch)
2013-03-22 18:47 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9877: Followup: FIX if the table is empty. (1.60 KB, patch)
2013-03-27 15:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9877: Followup: FIX if the table is empty. (1.70 KB, patch)
2013-04-02 16:17 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9877 - Use DataTables on funds administration page (3.53 KB, patch)
2013-04-03 07:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9877: Followup: FIX if the table is empty. (1.71 KB, patch)
2013-04-03 07:47 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-03-20 19:16:42 UTC
The funds administration page uses the old tablesorter plugin. It should use the DataTables plugin instead.
Comment 1 Owen Leonard 2013-03-20 19:25:55 UTC Comment hidden (obsolete)
Comment 2 Paul Poulain 2013-03-21 08:54:37 UTC
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Comment 3 Paul Poulain 2013-03-21 08:54:52 UTC Comment hidden (obsolete)
Comment 4 Paul Poulain 2013-03-21 09:11:36 UTC
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Comment 5 Paul Poulain 2013-03-21 09:11:53 UTC Comment hidden (obsolete)
Comment 6 Paul Poulain 2013-03-21 09:12:41 UTC
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Comment 7 Paul Poulain 2013-03-21 09:13:00 UTC Comment hidden (obsolete)
Comment 8 Jonathan Druart 2013-03-21 15:46:52 UTC
QA comment:

If I use the filter "Library" on the left and there is no result in the table, I got a DT error: 
  "DataTables warning (table id = 'budgeth'): Requested unknown parameter '1' from the data source for row 0"

Marked as Failed QA.
Comment 9 Owen Leonard 2013-03-22 18:47:32 UTC Comment hidden (obsolete)
Comment 10 Owen Leonard 2013-03-22 18:48:38 UTC
Returning to 'signed off' after minor correction. QA please set to 'needs signoff' if you disagree.
Comment 11 Jonathan Druart 2013-03-27 15:04:30 UTC Comment hidden (obsolete)
Comment 12 Jonathan Druart 2013-03-27 15:04:53 UTC
(In reply to comment #9)
> Created attachment 16818 [details] [review] [review]
...
> Post-QA revision adds handling for empty table: "No funds" row must have
> same number of cells as the rest of the table (including hidden cell);

I think we don't want to display the table if there is no data. Please sign-off my followup if you agree with that.
Comment 13 Owen Leonard 2013-04-02 16:17:42 UTC Comment hidden (obsolete)
Comment 14 Jonathan Druart 2013-04-03 07:47:19 UTC
QA comment:
Replace tablesorter with datatables on the funds admin page.
Marked as Passed QA.
Comment 15 Jonathan Druart 2013-04-03 07:47:39 UTC
Created attachment 17155 [details] [review]
Bug 9877 - Use DataTables on funds administration page

Replace the tablesorter plugin with the DataTables plugin on the funds
administration page.

To test, open the funds administration page (Administration ->
Funds). Confirm that table sorting, paging, and searching works
correctly.

Note that the table is sorted only when hierarchical display of parent
and child funds is not enabled. When the hierarchicial display is
enabled the table sorter is not triggered.

Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>

Post-QA revision adds handling for empty table: "No funds" row must have
same number of cells as the rest of the table (including hidden cell);

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 16 Jonathan Druart 2013-04-03 07:47:42 UTC
Created attachment 17156 [details] [review]
Bug 9877: Followup: FIX if the table is empty.

If there is no data, we don't display the table.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 17 Jared Camins-Esakov 2013-04-03 10:16:45 UTC
This patch has been pushed to master.