The funds administration page uses the old tablesorter plugin. It should use the DataTables plugin instead.
Created attachment 16557 [details] [review] Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered.
Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com>
Created attachment 16575 [details] [review] Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Created attachment 16581 [details] [review] Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
Created attachment 16582 [details] [review] Bug 5342: Followup Delete tags for letters which are not html Signed-off-by: Pierre Angot <tredok.pierre@gmail.com>
QA comment: If I use the filter "Library" on the left and there is no result in the table, I got a DT error: "DataTables warning (table id = 'budgeth'): Requested unknown parameter '1' from the data source for row 0" Marked as Failed QA.
Created attachment 16818 [details] [review] [SIGNED-OFF] Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Post-QA revision adds handling for empty table: "No funds" row must have same number of cells as the rest of the table (including hidden cell);
Returning to 'signed off' after minor correction. QA please set to 'needs signoff' if you disagree.
Created attachment 16936 [details] [review] Bug 9877: Followup: FIX if the table is empty. If there is no data, we don't display the table.
(In reply to comment #9) > Created attachment 16818 [details] [review] [review] ... > Post-QA revision adds handling for empty table: "No funds" row must have > same number of cells as the rest of the table (including hidden cell); I think we don't want to display the table if there is no data. Please sign-off my followup if you agree with that.
Created attachment 17148 [details] [review] [SIGNED-OFF] Bug 9877: Followup: FIX if the table is empty. If there is no data, we don't display the table. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA comment: Replace tablesorter with datatables on the funds admin page. Marked as Passed QA.
Created attachment 17155 [details] [review] Bug 9877 - Use DataTables on funds administration page Replace the tablesorter plugin with the DataTables plugin on the funds administration page. To test, open the funds administration page (Administration -> Funds). Confirm that table sorting, paging, and searching works correctly. Note that the table is sorted only when hierarchical display of parent and child funds is not enabled. When the hierarchicial display is enabled the table sorter is not triggered. Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> Post-QA revision adds handling for empty table: "No funds" row must have same number of cells as the rest of the table (including hidden cell); Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 17156 [details] [review] Bug 9877: Followup: FIX if the table is empty. If there is no data, we don't display the table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
This patch has been pushed to master.