The suggestions management page uses the old tablesorter plugin. It should use the DataTables plugin instead.
Created attachment 16558 [details] [review] Bug 9879 - Use DataTables on suggestions management page Replace the tablesorter plugin with the DataTables plugin on the suggestions management page. Table sorting has been coverted from using multiple specific IDs to a more efficient class-based selector. Unrelated change: Prevent page-jumping when checkbox links are clicked. To test, open the suggestions management page (Acquisitions -> Suggestions). Confirm that table sorting, paging, and searching works correctly.
I will accept this for 3.12, since it is fixing the general bug "Koha still uses tablesorter."
Patch tested with a sandbox, by Frederic Durand <frederic.durand@unilim.fr>
Created attachment 16572 [details] [review] Bug 9879 - Use DataTables on suggestions management page Replace the tablesorter plugin with the DataTables plugin on the suggestions management page. Table sorting has been coverted from using multiple specific IDs to a more efficient class-based selector. Unrelated change: Prevent page-jumping when checkbox links are clicked. To test, open the suggestions management page (Acquisitions -> Suggestions). Confirm that table sorting, paging, and searching works correctly. Signed-off-by: Frederic Durand <frederic.durand@unilim.fr>
QA comment: This patch replaces tablesorter with Datatable on the suggestions management page. Owen uses "e.preventDefault()" where I would use "return false;", but it does the same job! Marked as Passed QA.
Created attachment 16668 [details] [review] Bug 9879 - Use DataTables on suggestions management page
This patch has been pushed to master.