The offline circulation page which lists transactions ready to process includes the old tablesorter plugin even though it is unused. This reference should be removed.
Created attachment 16563 [details] [review] Bug 9881 - Remove unused tablesorter plugin from offline circulation page The offline circulation list template doesn't need to include the tablesorter plugin, it's unused. This patch removes it. To test, submit some circulation transactions through the Firefox offline circulation addon. Load the offline circ page (offline_circ/list.pl). Confirm that there are no JavaScript errors, and that "check/uncheck all" links work correctly.
Created attachment 16564 [details] [review] Bug 9881 - Remove unused tablesorter plugin from offline circulation page The offline circulation list template doesn't need to include the tablesorter plugin, it's unused. This patch removes it. To test, submit some circulation transactions through the Firefox offline circulation addon. Load the offline circ page (offline_circ/list.pl). Confirm that there are no JavaScript errors, and that "check/uncheck all" links work correctly. Signoff comment: Test plan works as expected. Firebug and Chrome's builtin developer tool don't raise any errors. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Created attachment 16912 [details] [review] [PASSED QA] Bug 9881 - Remove unused tablesorter plugin from offline circulation page The offline circulation list template doesn't need to include the tablesorter plugin, it's unused. This patch removes it. To test, submit some circulation transactions through the Firefox offline circulation addon. Load the offline circ page (offline_circ/list.pl). Confirm that there are no JavaScript errors, and that "check/uncheck all" links work correctly. Signoff comment: Test plan works as expected. Firebug and Chrome's builtin developer tool don't raise any errors. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> One line change, followed test plan, no negative consequences found.
This patch has been pushed to master.