Bug 9881 - Remove unused tablesorter plugin from offline circulation page
Summary: Remove unused tablesorter plugin from offline circulation page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL: /cgi-bin/koha/offline_circ/list.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-21 00:46 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9881 - Remove unused tablesorter plugin from offline circulation page (1.48 KB, patch)
2013-03-21 00:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9881 - Remove unused tablesorter plugin from offline circulation page (1.61 KB, patch)
2013-03-21 02:33 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[PASSED QA] Bug 9881 - Remove unused tablesorter plugin from offline circulation page (1.73 KB, patch)
2013-03-26 22:39 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-03-21 00:46:55 UTC
The offline circulation page which lists transactions ready to process includes the old tablesorter plugin even though it is unused. This reference should be removed.
Comment 1 Owen Leonard 2013-03-21 00:54:35 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2013-03-21 02:33:19 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-03-26 22:39:18 UTC
Created attachment 16912 [details] [review]
[PASSED QA] Bug 9881 - Remove unused tablesorter plugin from offline circulation page

The offline circulation list template doesn't need to include the
tablesorter plugin, it's unused. This patch removes it.

To test, submit some circulation transactions through the Firefox
offline circulation addon. Load the offline circ page
(offline_circ/list.pl). Confirm that there are no JavaScript errors, and
that "check/uncheck all" links work correctly.

Signoff comment: Test plan works as expected. Firebug and Chrome's builtin developer tool don't raise any errors.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
One line change, followed test plan, no negative
consequences found.
Comment 4 Jared Camins-Esakov 2013-03-28 02:45:26 UTC
This patch has been pushed to master.