Bug 9905 - Use DataTables on calendar page
Summary: Use DataTables on calendar page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL: /cgi-bin/koha/tools/holidays.pl
Keywords:
Depends on: 9887
Blocks:
  Show dependency treegraph
 
Reported: 2013-03-22 16:20 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9905 - Use DataTables on calendar page (10.22 KB, patch)
2013-03-22 18:19 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9905 - Use DataTables on calendar page (10.24 KB, patch)
2013-04-07 03:04 UTC, Chris Cormack
Details | Diff | Splinter Review
screenshot showing missing calendar and holidays (53.51 KB, image/png)
2013-04-07 20:44 UTC, Katrin Fischer
Details
[PASSED QA] Bug 9905 - Use DataTables on calendar page (10.40 KB, patch)
2013-04-09 21:02 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 9905 - Use DataTables on calendar page (10.40 KB, patch)
2013-04-09 21:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-03-22 16:20:32 UTC
The calendar tool uses the old tablesorter plugin to sort tables of existing calendar entries. It should use DataTables instead.
Comment 1 Owen Leonard 2013-03-22 18:19:57 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-04-07 03:04:13 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-04-07 20:44:24 UTC
Created attachment 17268 [details]
screenshot showing missing calendar and holidays

I found 2 problems with this patch:

1) The calendar for my logged in library does not appar, but when I switch to another library the display is ok. 

2) The Day/Month column in the 'Yearly - Repeatable Holidays' doesn't sort, but gives a JavaScript error. 

Owen, could you check what's going wrong there?
Comment 4 Owen Leonard 2013-04-09 12:30:30 UTC
Returning to "signed off" for more testing. Be sure to have 9887 applied first.
Comment 5 Katrin Fischer 2013-04-09 21:02:45 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-04-09 21:03:12 UTC
Created attachment 17321 [details] [review]
[PASSED QA] Bug 9905 - Use DataTables on calendar page

The calendar management page uses the old tablesorter plugin. This patch
replaces tablesorter code with DataTables.

In order to easily sort date columns under various dateformat system
preference settings, date columns now sort based on an unformatted date
in a <span>'s title attribute (requiring the patch for Bug 9887).

To test, view the calendar page--preferably with plenty of existing
holiday data to populate the holiday summary tables. Confirm that
sorting works correctly on all sorted tables with the dateformat
preference set in all settings.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Note: This has to be tested together with the patch for bug 9887.
All tests and QA script pass.
Comment 7 Jared Camins-Esakov 2013-04-15 13:13:57 UTC
This patch has been pushed to master and 3.12.x.