The calendar tool uses the old tablesorter plugin to sort tables of existing calendar entries. It should use DataTables instead.
Created attachment 16817 [details] [review] Bug 9905 - Use DataTables on calendar page The calendar management page uses the old tablesorter plugin. This patch replaces tablesorter code with DataTables. In order to easily sort date columns under various dateformat system preference settings, date columns now sort based on an unformatted date in a <span>'s title attribute (requiring the patch for Bug 9887). To test, view the calendar page--preferably with plenty of existing holiday data to populate the holiday summary tables. Confirm that sorting works correctly on all sorted tables with the dateformat preference set in all settings.
Created attachment 17224 [details] [review] Bug 9905 - Use DataTables on calendar page The calendar management page uses the old tablesorter plugin. This patch replaces tablesorter code with DataTables. In order to easily sort date columns under various dateformat system preference settings, date columns now sort based on an unformatted date in a <span>'s title attribute (requiring the patch for Bug 9887). To test, view the calendar page--preferably with plenty of existing holiday data to populate the holiday summary tables. Confirm that sorting works correctly on all sorted tables with the dateformat preference set in all settings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17268 [details] screenshot showing missing calendar and holidays I found 2 problems with this patch: 1) The calendar for my logged in library does not appar, but when I switch to another library the display is ok. 2) The Day/Month column in the 'Yearly - Repeatable Holidays' doesn't sort, but gives a JavaScript error. Owen, could you check what's going wrong there?
Returning to "signed off" for more testing. Be sure to have 9887 applied first.
Created attachment 17320 [details] [review] [PASSED QA] Bug 9905 - Use DataTables on calendar page The calendar management page uses the old tablesorter plugin. This patch replaces tablesorter code with DataTables. In order to easily sort date columns under various dateformat system preference settings, date columns now sort based on an unformatted date in a <span>'s title attribute (requiring the patch for Bug 9887). To test, view the calendar page--preferably with plenty of existing holiday data to populate the holiday summary tables. Confirm that sorting works correctly on all sorted tables with the dateformat preference set in all settings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Note: This has to be tested together with the patch for bug 9887. All tests and QA script pass.
Created attachment 17321 [details] [review] [PASSED QA] Bug 9905 - Use DataTables on calendar page The calendar management page uses the old tablesorter plugin. This patch replaces tablesorter code with DataTables. In order to easily sort date columns under various dateformat system preference settings, date columns now sort based on an unformatted date in a <span>'s title attribute (requiring the patch for Bug 9887). To test, view the calendar page--preferably with plenty of existing holiday data to populate the holiday summary tables. Confirm that sorting works correctly on all sorted tables with the dateformat preference set in all settings. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Note: This has to be tested together with the patch for bug 9887. All tests and QA script pass.
This patch has been pushed to master and 3.12.x.