Created attachment 16858 [details] [review] proposed patch the patch 7129 introduces a bug if the unitprice is 0.0000. Instead of showing in this case the 'ecost' if there is not 'unitprice', it shows 0.00 and the 'Actual cost' must be manually entered. The line : if ( @$results[0]->{'unitprice'} == 0 ) { @$results[0]->{'unitprice'} = ''; was wrote in this perspective. But sprintf ( "%.2f", with '' or 0 or any string will return 0.00 and then, in the .tt 'unitprice' exists so we have the bad result. Jared Camins-Esakov : If this is fixing a bug caused by 7129 it should be moved to a new bug, which can be set straight to So I create this one and mark it as "Passed QA.".
This patch has been pushed to master.
Does not apply to 3.10.x or 3.8.x please resubmit if it is needed on those branches
Created attachment 18060 [details] [review] [3.10.x] Bug 9923 - correction of a bug due to bz 7129 Patch rebased for 3.10.x. Also applies on 3.8.x.
Applied cleanly to 3.10.x will be in 3.10.6. Still conflicts for 3.8.x
Created attachment 18131 [details] [review] patch rebased for 3.8.x Hi Chris, I have added a line in the comment. rebased for 3.8.x thx
Pushed to 3.8.x will be in 3.8.13