example of glitchy file to follow...
the ./debian/control file currently has syntax errors on these lines... $ grep '|' ./debian/control libcgi-pm-perl | perl-modules, libdigest-sha-perl | perl, libfile-path-perl | perl-modules, libgd-gd2-noxpm-perl | libgd-gd2-perl, libmodule-load-conditional-perl | perl-modules, libtest-simple-perl | perl-modules, libcgi-pm-perl | perl-modules, libdigest-sha-perl | perl, libfile-path-perl | perl-modules, libgd-gd2-noxpm-perl | libgd-gd2-perl, libmodule-load-conditional-perl | perl-modules, libtest-simple-perl | perl-modules,
(In reply to comment #1) > the ./debian/control file currently has syntax errors on these lines... ps: i'll create a patch for this
(In reply to comment #2) > (In reply to comment #1) > > the ./debian/control file currently has syntax errors on these lines... > > ps: i'll create a patch for this oops, '|' chars are allowed, so its not a syntax error http://www.debian.org/doc/debian-policy/ch-relationships.html#s-sourcebinarydeps but still, we can improve this script to choose the newest version of each of these packages above, rather than defaulting to the oldest version in the 'perl-modules' package
Created attachment 16915 [details] [review] Bug 9927 - tweak list-deps script to build a better ./debian/control file to test... 1/ apply patch 2/ delete existing ./debian.control file rm ./debian.control 3/ run script ./debian.control/update-debian 4/ view new ./debian.control file more ./debian.control
Created attachment 16916 [details] [review] Bug 9927 - tweak list-deps script to build a better ./debian/control file to test... 1/ apply patch 2/ delete existing file rm ./debian/control 3/ run script ./debian/update-control 4/ view new file more ./debian/control
Why is this necessary?
(In reply to comment #6) > Why is this necessary? its necessary, so that the latest available version of all Koha's dependency packages are installed. before this patch, this doesn't happen example.. before the patch you end up with the old version of CGI.pm from the 'perl-modules' package $CGI::revision = '$Id: CGI.pm,v 1.263 2009/02/11 16:56:37 lstein Exp $'; $CGI::VERSION='3.43'; after the patch you end up with the new version of CGI.pm from the 'libcgi-pm-perl' package $CGI::revision = '$Id: CGI.pm,v 1.266 2009/07/30 16:32:34 lstein Exp $'; $CGI::VERSION='3.49';
Created attachment 16997 [details] Bug 9928 - no way to see all purchase suggestions at all Test Plan: 1) Apply patch 3) Create suggestions for multiple libraries 2) Select 'Any' for the 'For' field under 'Acquisition information' 3) Note you are seeing the suggestions for all branches Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Works as described Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Whoops wrong one
The content of attachment 16997 [details] has been deleted by Chris Cormack <chris@bigballofwax.co.nz> without providing any reason. The token used to delete this attachment was generated at 2013-03-29 21:52:55 NZDT.
Resetting to ASSIGNED since Mason is planning on providing a new patch.
(In reply to comment #7) > (In reply to comment #6) > > Why is this necessary? > > its necessary, so that the latest available version of all Koha's dependency > packages are installed. before this patch, this doesn't happen > after some further discussion with Robin, we discovered that it was a better choice to select the version from perl's base packages, rather than the 'other' package (this was the opposite of what i initially thought) the reason is - the base perl packages have more security testing this patch always chooses the *base* perl packages, not the alternative
Created attachment 17670 [details] [review] Bug 9927 - tweak list-deps script to build a better ./debian/control file to test... 1/ apply patch 2/ rename existing file mv ./debian/control ./debian/control.old 3/ run script ./debian/update-control 4/ compare files, to see improvements diff ./debian/control ./debian/control.old
Created attachment 17674 [details] [review] Bug 9927 - tweak list-deps script to build a better ./debian/control file to test... 1/ rename existing file mv ./debian/control ./debian/control.old 2/ apply patch 3/ run script ./debian/update-control 4/ compare control files, to see improvements diff ./debian/control ./debian/control.old
I'm still not sold on the need for this, in an "if it ain't broke" kinda way.
(In reply to Robin Sheat from comment #15) > I'm still not sold on the need for this, in an "if it ain't broke" kinda way. Indeed. Can you supply examples of specific packages where you believe that a non-optimal version is being installed?
I agree with the previous two comments by the previous two packaging managers. I don't see what this is fixing, and it will likely lead to problems as we support several versions of several Debian-based distributions with different Perl versions. Closing wontfix.