Bug 9927 - tweak list-deps script to build a better ./debian/control file
Summary: tweak list-deps script to build a better ./debian/control file
Status: CLOSED WONTFIX
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P3 major (vote)
Assignee: Mason James
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-26 07:05 UTC by Mason James
Modified: 2019-10-14 19:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9927 - tweak list-deps script to build a better ./debian/control file (5.22 KB, patch)
2013-03-26 23:08 UTC, Mason James
Details | Diff | Splinter Review
Bug 9927 - tweak list-deps script to build a better ./debian/control file (5.18 KB, patch)
2013-03-26 23:11 UTC, Mason James
Details | Diff | Splinter Review
Bug 9928 - no way to see all purchase suggestions at all (deleted)
2013-03-29 08:51 UTC, Chris Cormack
Details
Bug 9927 - tweak list-deps script to build a better ./debian/control file (1.93 KB, patch)
2013-04-25 08:32 UTC, Mason James
Details | Diff | Splinter Review
Bug 9927 - tweak list-deps script to build a better ./debian/control file (6.93 KB, patch)
2013-04-25 09:47 UTC, Mason James
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2013-03-26 07:05:24 UTC
example of glitchy file to follow...
Comment 1 Mason James 2013-03-26 09:41:38 UTC
the ./debian/control file currently has syntax errors on these lines...

$ grep '|'   ./debian/control
 libcgi-pm-perl | perl-modules,
 libdigest-sha-perl | perl,
 libfile-path-perl | perl-modules,
 libgd-gd2-noxpm-perl | libgd-gd2-perl,
 libmodule-load-conditional-perl | perl-modules,
 libtest-simple-perl | perl-modules,
 libcgi-pm-perl | perl-modules,
 libdigest-sha-perl | perl,
 libfile-path-perl | perl-modules,
 libgd-gd2-noxpm-perl | libgd-gd2-perl,
 libmodule-load-conditional-perl | perl-modules,
 libtest-simple-perl | perl-modules,
Comment 2 Mason James 2013-03-26 09:43:38 UTC
(In reply to comment #1)
> the ./debian/control file currently has syntax errors on these lines...

ps: i'll create a patch for this
Comment 3 Mason James 2013-03-26 12:24:37 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > the ./debian/control file currently has syntax errors on these lines...
> 
> ps: i'll create a patch for this


oops,  '|' chars are allowed, so its not a syntax error

 http://www.debian.org/doc/debian-policy/ch-relationships.html#s-sourcebinarydeps


but still, we can improve this script to choose the newest version of each of these packages above, rather than defaulting to the oldest version in the 'perl-modules' package
Comment 4 Mason James 2013-03-26 23:08:34 UTC Comment hidden (obsolete)
Comment 5 Mason James 2013-03-26 23:11:25 UTC Comment hidden (obsolete)
Comment 6 Robin Sheat 2013-03-27 22:40:54 UTC
Why is this necessary?
Comment 7 Mason James 2013-03-28 02:21:34 UTC
(In reply to comment #6)
> Why is this necessary?

its necessary, so that the latest available version of all Koha's dependency packages are installed. before this patch, this doesn't happen


example..

before the patch you end up with the old version of CGI.pm from the 'perl-modules' package

 $CGI::revision = '$Id: CGI.pm,v 1.263 2009/02/11 16:56:37 lstein Exp $';   
 $CGI::VERSION='3.43'; 


after the patch you end up with the new version of CGI.pm from the 'libcgi-pm-perl' package

 $CGI::revision = '$Id: CGI.pm,v 1.266 2009/07/30 16:32:34 lstein Exp $';   
 $CGI::VERSION='3.49';
Comment 8 Chris Cormack 2013-03-29 08:51:18 UTC Comment hidden (obsolete)
Comment 9 Chris Cormack 2013-03-29 08:52:14 UTC
Whoops wrong one
Comment 10 Chris Cormack 2013-03-29 08:52:59 UTC
The content of attachment 16997 [details] has been deleted by
    Chris Cormack <chris@bigballofwax.co.nz>
without providing any reason.

The token used to delete this attachment was generated at 2013-03-29 21:52:55 NZDT.
Comment 11 Jared Camins-Esakov 2013-04-03 12:24:59 UTC
Resetting to ASSIGNED since Mason is planning on providing a new patch.
Comment 12 Mason James 2013-04-25 08:31:37 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > Why is this necessary?
> 
> its necessary, so that the latest available version of all Koha's dependency
> packages are installed. before this patch, this doesn't happen
> 

after some further discussion with Robin, we discovered that it was a better choice to select the version from perl's base packages, rather than the 'other' package (this was the opposite of what i initially thought)

the reason is - the base perl packages have more security testing

this patch always chooses the *base* perl packages, not the alternative
Comment 13 Mason James 2013-04-25 08:32:39 UTC Comment hidden (obsolete)
Comment 14 Mason James 2013-04-25 09:47:10 UTC
Created attachment 17674 [details] [review]
Bug 9927 - tweak list-deps script to build a better ./debian/control file

to test...

1/ rename existing file
    mv ./debian/control ./debian/control.old

2/ apply patch

3/ run script
    ./debian/update-control

4/ compare control files, to see improvements
    diff ./debian/control ./debian/control.old
Comment 15 Robin Sheat 2013-05-09 22:46:41 UTC
I'm still not sold on the need for this, in an "if it ain't broke" kinda way.
Comment 16 Galen Charlton 2013-07-03 23:36:47 UTC
(In reply to Robin Sheat from comment #15)
> I'm still not sold on the need for this, in an "if it ain't broke" kinda way.

Indeed.  Can you supply examples of specific packages where you believe that a non-optimal version is being installed?
Comment 17 Mirko Tietgen 2018-05-30 12:48:55 UTC
I agree with the previous two comments by the previous two packaging managers.
I don't see what this is fixing, and it will likely lead to problems as we support several versions of several Debian-based distributions with different Perl versions. Closing wontfix.