I think we might be missing a parameter for the branch here - when editing or adding circulation rules for a specific library the change is made to all libraries instead. Also upon saving the screen switches to all libraries and does not stay on the selected specific library.
I concur, I can recreate this bug, working on a fix now
Created attachment 17271 [details] [review] Bug 9933: Unable to edit or add rules for any branch except default To test 1/ Select a branch in circ rules 2/ Edit or add a rule, note this change is made for default instead of the library you selected 3/ Apply the patch 4/ Try 1 and 2 again
Created attachment 17276 [details] [review] Bug 9933: Unable to edit or add rules for any branch except default To test 1/ Select a branch in circ rules 2/ Edit or add a rule, note this change is made for default instead of the library you selected 3/ Apply the patch 4/ Try 1 and 2 again Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected.
Created attachment 17277 [details] [review] Bug 9933: Unable to edit or add rules for any branch except default To test 1/ Select a branch in circ rules 2/ Edit or add a rule, note this change is made for default instead of the library you selected 3/ Apply the patch 4/ Try 1 and 2 again Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected. Signed-off-by: Mason James <mtj@kohaaloha.com>
(In reply to comment #4) > Created attachment 17277 [details] [review] [review] > Bug 9933: Unable to edit or add rules for any branch except default > > To test > 1/ Select a branch in circ rules > 2/ Edit or add a rule, note this change is made for default instead of > the library you selected > 3/ Apply the patch > 4/ Try 1 and 2 again > > Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> > Works as expected. > Signed-off-by: Mason James <mtj@kohaaloha.com> works for me too, passing qa...
This patch has been pushed to master and 3.12.x.