Bug 9940 - Add a new index for original language of document
Summary: Add a new index for original language of document
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Mathieu Saby
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-27 19:27 UTC by Mathieu Saby
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
[PATCH] Bug 9940 : Add a new index for the original language of a document (8.60 KB, patch)
2013-04-28 13:27 UTC, Mathieu Saby
Details | Diff | Splinter Review
[PATCH] Bug 9940 : Add a new index for the original language of a document (8.65 KB, patch)
2013-10-24 20:58 UTC, Mathieu Saby
Details | Diff | Splinter Review
Bug 9940 : Add a new index for the original language of a document (8.76 KB, patch)
2013-12-23 20:41 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 9940 : Add a new index for the original language of a document (8.82 KB, patch)
2013-12-24 10:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9940: (followup) FIX comment: language-original is 101$c, not $h (1.22 KB, patch)
2013-12-24 10:30 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-03-27 19:27:06 UTC
It could be usefull to add a new index for original language of document.

Ex : In UNIMARC, if a book printed in french is a translation of a german one, at present, we can make a search using "ln" index, mapped with 101$afre, but we cannot search for the original language, stored in 101$cger.

M. Saby
Comment 1 Mathieu Saby 2013-04-28 13:27:46 UTC Comment hidden (obsolete)
Comment 2 Mathieu Saby 2013-09-23 20:40:24 UTC
Nobody interested by this new index?

M. Saby
Comment 3 I'm just a bot 2013-10-24 19:27:15 UTC
Applying: Bug 9940 : Add a new index for the original language of a document
Using index info to reconstruct a base tree...
M	C4/Search.pm
M	etc/zebradb/biblios/etc/bib1.att
M	etc/zebradb/ccl.properties
M	etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
M	etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
M	etc/zebradb/marc_defs/marc21/biblios/record.abs
M	etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
M	etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
M	etc/zebradb/marc_defs/unimarc/biblios/record.abs
Falling back to patching base and 3-way merge...
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/record.abs
CONFLICT (content): Merge conflict in etc/zebradb/marc_defs/unimarc/biblios/record.abs
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl
Auto-merging etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml
Auto-merging etc/zebradb/marc_defs/marc21/biblios/record.abs
Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
Auto-merging etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
Auto-merging etc/zebradb/ccl.properties
Auto-merging etc/zebradb/biblios/etc/bib1.att
Auto-merging C4/Search.pm
Patch failed at 0001 Bug 9940 : Add a new index for the original language of a document
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Comment 4 Mathieu Saby 2013-10-24 20:58:20 UTC Comment hidden (obsolete)
Comment 5 Chris Cormack 2013-12-23 20:41:12 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-12-24 10:29:10 UTC
Tested ok for unimarc.
Marked as Passed QA.
Comment 7 Jonathan Druart 2013-12-24 10:29:52 UTC
Created attachment 23804 [details] [review]
Bug 9940 : Add a new index for the original language of a document

It could be useful to index the original language of a document (i.e. "fre" for the english translation of a french novel).
This patch rename 1095 bib1 attribute (Code-language-original => language-original) and use it to index :
- MARC21 041$h subfield
- UNIMARC 101$c subfield
It adds "language-original" in the list of index in Search.pm.

Test plan :
A. in a MARC21 GRS1 environment
1. Copy Zebra config files (zebradb/biblios/etc/bib1.att, zebradb/ccl.properties, marc_defs/marc21/biblios/record.abs) from your source etc/ directory to your main koha etc/ directory
2. Reindex zebra
3. Make some searches, like "language-original:fre"
B. in a MARC21 DOM environment
4. Copy Zebra config files (zebradb/biblios/etc/bib1.att, zebradb/ccl.properties, marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl) from your source etc/ directory to your main koha etc/ directory
5. Reindex zebra
6. Make some searches, like "language-original:fre"
C. in a UNIMARC GRS1 environment
7. Copy Zebra config files (zebradb/biblios/etc/bib1.att, zebradb/ccl.properties, marc_defs/unimarc/biblios/record.abs) from your source etc/ directory to your main koha etc/ directory
8. Reindex zebra
9. Make some searches, like "language-original:fre"
A. in a UNIMARC DOM environment
10. Copy Zebra config files (zebradb/biblios/etc/bib1.att, zebradb/ccl.properties, marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl) from your source etc/ directory to your main koha etc/ directory
11. Reindex zebra
12. Make some searches, like "language-original:fre"

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2013-12-24 10:30:00 UTC
Created attachment 23805 [details] [review]
Bug 9940: (followup) FIX comment: language-original is 101$c, not $h

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Galen Charlton 2013-12-25 15:52:47 UTC
Pushed to master.  Thanks, Mathieu!
Comment 10 Fridolin Somers 2014-01-03 09:01:25 UTC
Patches pushed to 3.14.x, will be in 3.14.2.