When in opac-topissues using filter "of the last:" with value "No limit", the result shows the caption : "The 10 most checked-out in the past 999 months".
Created attachment 16967 [details] [review] Proposed patch See commit comment. Very small patch
Created attachment 17075 [details] [review] Bug 9946 - opac-topissues with no time limit When in opac-topissues using filter "of the last:" with value "No limit", the result shows the caption : "The 10 most checked-out in the past 999 months". This patch corrects a typo error : $timeLimit was used instead of $timeLimitFinite Test plan : - Go to OPAC most popular - Select "No limit" in last filter and submit => Check that result displays caption : "The 10 most checked-out of all time" - Come back - Select "6 months" in last filter and submit => Check that result displays caption : "The 10 most checked-out in the past 6 months" Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
I am not very happy about the behaviour of this page and I think it needs more fixes (see bug 9959) 1) Why do I have to double submit my search sometimes? - go to top issues from opac start page - change filter from last 3 months to no limit - submit 2) Why are the search options of this second form different to the first form? - library changes from Union to Demo for me 3) Why does hitting the submit button on the filter left sometimes change the filters too? - library changes from all libraries to Union (last in list)
Created attachment 17089 [details] [review] [PASSED QA] Bug 9946 - opac-topissues with no time limit When in opac-topissues using filter "of the last:" with value "No limit", the result shows the caption : "The 10 most checked-out in the past 999 months". This patch corrects a typo error : $timeLimit was used instead of $timeLimitFinite Test plan : - Go to OPAC most popular - Select "No limit" in last filter and submit => Check that result displays caption : "The 10 most checked-out of all time" - Come back - Select "6 months" in last filter and submit => Check that result displays caption : "The 10 most checked-out in the past 6 months" Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script.
This patch has been pushed to master.