Bug 9957 - Missing cancel link on subfield editing page
Summary: Missing cancel link on subfield editing page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-03-31 11:33 UTC by Katrin Fischer
Modified: 2013-12-05 20:09 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9957 - Missing cancel link on subfield editing page (3.24 KB, patch)
2013-04-30 18:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9957 - Missing cancel link on subfield editing page (3.26 KB, patch)
2013-04-30 21:27 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 9957 - Missing cancel link on subfield editing page (3.38 KB, patch)
2013-05-01 06:15 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-03-31 11:33:15 UTC
When editing subfields it's a bit irritating that the save link is placed on top. So most of the time you have to scroll back up, especially when you have changed things in the 'more constraints' part. Also, unlike on other pages there is no 'cancel' link.
Comment 1 Owen Leonard 2013-04-30 18:44:05 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-04-30 21:27:48 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-05-01 06:15:27 UTC
Created attachment 17860 [details] [review]
[PASSED QA] Bug 9957 - Missing cancel link on subfield editing page

The subfield edit page has an edit bottom at the top of the page. Almost
no other edit screens do this. It would be more consistent to put it at
the bottom. Also missing is a "cancel" link. This patch fixes both
issues.

The patch also adds "Default" to the breadcrumbs when editing a subfield
in the default framework.

To test, apply the patch and edit a subfield: MARC frameworks -> MARC
structure -> Subfields -> Edit. The "Save changes" button should appear
at the bottom of the page alonside a "Cancel" link. Both should work
correctly.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Template change only, improves consistency and works
nicely.
Comment 4 Jared Camins-Esakov 2013-05-01 11:22:58 UTC
This patch has been pushed to master and 3.12.x.
Comment 5 Chris Cormack 2013-05-09 06:55:45 UTC
Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13