In file "etc\zebradb\ccl.properties" the label "Local-number" is being abbreviated by "sn", it seems an error because "sn" should be the abbreviation of "standard number". The label of standard number is "Identifier-standard" abbreviated by "ident". The standard numbers sholud be the 020, 022 and 024 MARC fields and not the in 001 and 035 fields. For this reason searching in Advanced Search is wrong in "search-indexes.inc" it find the following code: [% IF (numbersphr) %] <option value="sn,phr">Standard number</option> [% ELSE %] <option value="sn">Standard number</option> [% END %] Should be: [% IF (numbersphr) %] <option value="ident,phr">Standard number</option> [% ELSE %] <option value="ident">Standard number</option> [% END %]
Created attachment 75351 [details] [review] Bug 9968: Fix wrong index for Standard number in advanced and label search 'Standard number' indicates that you can search ISBN, ISSN and other standard numbers, but we are using the wrong index and only get a very limited search for biblionumber instead. This patch changes the index from sn to ident. To test: - Check both staff and OPAC advanced search: - Search for Standard number = ISBN - Search for Standard number = ISSN Both should work. Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences - Check the label creator - Add a new batch - Use 'add items' option and search for Standard number
Not sure if related, but no searches of any kind work in Sandbox 14, on either the staff or OPAC side (database 1, w/ 450 records). Unable to test :-(
This only touches some template files so should not be related. Could you try another box? Maybe take a look and switch the searchengine preference to Zebra.
It's unclear to me from the test plan what the expected results should be when the [Intranet|OPAC]NumbersPreferPhrase system preferences are toggled. *General* Standard number searches work in Sandbox 05 when these are set to Use (the operator "phr" in the callnumber and standard number staff client searches). They fail when set to Don't use. (Searches using the specific ISBN & ISSN fields work with both settings.) Label creation works fine with either setting as long as ISBN or ISSN is set as the search field. No results, however, with either setting when searching by the general Standard number field.
Created attachment 79862 [details] [review] Bug 9968: Fix wrong index for Standard number in advanced and label search 'Standard number' indicates that you can search ISBN, ISSN and other standard numbers, but we are using the wrong index and only get a very limited search for biblionumber instead. This patch changes the index from sn to ident. To test: - Check both staff and OPAC advanced search: - Search for Standard number = ISBN - Search for Standard number = ISSN Both should work. Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences - Check the label creator - Add a new batch - Use 'add items' option and search for Standard number Signed-off-by: Michal Denar <black23@gmail.com>
Thx Michal!
Created attachment 80020 [details] [review] Bug 9968: Fix wrong index for Standard number in advanced and label search 'Standard number' indicates that you can search ISBN, ISSN and other standard numbers, but we are using the wrong index and only get a very limited search for biblionumber instead. This patch changes the index from sn to ident. To test: - Check both staff and OPAC advanced search: - Search for Standard number = ISBN - Search for Standard number = ISSN Both should work. Toggle [Intranet|OPAC]NumbersPreferPhrase system preferences - Check the label creator - Add a new batch - Use 'add items' option and search for Standard number Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Awesome work all! Pushed to master for 18.11
Pushed to 18.05.x for 18.05.05
Pushed to 17.11.x for 17.11.12