Bug 9970 - Add datepicker widget default configuration to OPAC patron entry form
Summary: Add datepicker widget default configuration to OPAC patron entry form
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 12:57 UTC by Owen Leonard
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9970 - Add datepicker default configuration to OPAC patron entry form (1.60 KB, patch)
2013-04-02 13:16 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9970 - Add datepicker default configuration to OPAC patron entry form (1.68 KB, patch)
2013-04-02 22:30 UTC, David Cook
Details | Diff | Splinter Review
Bug 9970 - Add datepicker default configuration to OPAC patron entry form (1.73 KB, patch)
2013-04-03 09:04 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-04-02 12:57:21 UTC
The patron entry form in the OPAC (opac-memberentry.pl) has a datepicker widget but doesn't include the include file which sets some datepicker widget defaults. calendar.inc includes translatable strings for labels on the calendar and the path to the calendar image associated with datepicker form fields.
Comment 1 Owen Leonard 2013-04-02 13:16:45 UTC Comment hidden (obsolete)
Comment 2 David Cook 2013-04-02 22:30:54 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-04-03 09:04:40 UTC
Created attachment 17159 [details] [review]
Bug 9970 - Add datepicker default configuration to OPAC patron entry form

The datepicker on the OPAC patron entry/update form
(opac-memberentry.pl) doesn't show a calendar icon. This is because
although there is in-page JS to trigger the widget, the page doesn't
include the file which sets some widget defaults, including the path to
the calendar icon and the translatable strings for calendar labels.

This patch simply adds calendar.inc to the template.

To test, load the patron entry/update form (click "personal details" for
an existing patron or a start new patron registration). The date of
birth entry field should show a calendar icon.

Signed-off-by: David Cook <dcook@prosentient.com.au>

Test plan works as described. Looks much better.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jared Camins-Esakov 2013-04-03 10:12:24 UTC
This patch has been pushed to master.