Bug 9971 - Plugins system is broken!
Summary: Plugins system is broken!
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low critical (vote)
Assignee: Kyle M Hall
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 13:02 UTC by Kyle M Hall
Modified: 2019-06-27 09:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9971 - Plugins system is broken! (1.41 KB, patch)
2013-04-02 13:04 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9971 - Plugins system is broken! (1.51 KB, patch)
2013-04-02 14:45 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9971 - Plugins system is broken! (1.52 KB, patch)
2013-04-03 08:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-04-02 13:02:28 UTC
Trying to run a plugin results in the following error:

Software error:

Undefined subroutine &Koha::Plugins::Base::get_template_and_user called at /home/koha/kohaclone/Koha/Plugins/Base.pm line 108.

The is caused by the change from 'use C4::Auth' to 'require C4::Auth' which does not export get_template_and_user.
Comment 1 Kyle M Hall 2013-04-02 13:04:13 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2013-04-02 14:45:53 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-04-03 08:52:56 UTC
Created attachment 17158 [details] [review]
Bug 9971 - Plugins system is broken!

Trying to run a plugin results in the following error:

Software error:

Undefined subroutine &Koha::Plugins::Base::get_template_and_user called
at /home/koha/kohaclone/Koha/Plugins/Base.pm line 108.

The is caused by the change from 'use C4::Auth' to 'require C4::Auth'
which does not export get_template_and_user.

Test Plan:
1) Install the KitchenSink plugin
2) Try to run the report, tool or configuration for the plugin
3) Note the error
4) Apply the patch
5) Try again

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jared Camins-Esakov 2013-04-03 10:02:43 UTC
This patch has been pushed to master.