Bug 9986 - Two fixes on Z3950 Search
Summary: Two fixes on Z3950 Search
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Z39.50 / SRU / OpenSearch Servers (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Marcel de Rooy
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-03 14:36 UTC by Marcel de Rooy
Modified: 2014-05-26 21:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9986: Two fixes for Z3950 search (3.07 KB, patch)
2013-04-03 14:43 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 9986: Two fixes for Z3950 search (3.07 KB, patch)
2013-04-03 14:57 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 9986: Two fixes for Z3950 search (3.12 KB, patch)
2013-04-03 15:05 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9986: Two fixes for Z3950 search (3.40 KB, patch)
2013-04-07 14:46 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 9986: Two fixes for Z3950 search (3.41 KB, patch)
2013-04-07 17:29 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2013-04-03 14:36:48 UTC
Two fixes in this patch:

Searching for stdid: Standard ID, srchany: RAW (any) somehow did not work anymore. Probably my fault :) Note that these two fields are in Cataloging Z3950 search and not in Acquisition.

Fixing encoding problems: When adding -utf flag for CGI in acqui/z3950 and cataloging/z3950, the decoding statements in C4/Breeding's Z3950Search should be removed.

Test plan:
Search in Cataloging with:
Standard ID: 9782358670043 on GETTY's
RAW (any): musée on GETTY's  -- Note the diacritic

Search in Acquisition
Somewhere, does not matter, but use a diacritic.
Comment 1 Marcel de Rooy 2013-04-03 14:43:57 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2013-04-03 14:45:42 UTC
Problem with é in the commit message..
Comment 3 Marcel de Rooy 2013-04-03 14:57:04 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2013-04-03 15:05:46 UTC Comment hidden (obsolete)
Comment 5 Bernardo Gonzalez Kriegel 2013-04-07 14:46:53 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-04-07 17:29:15 UTC
Created attachment 17262 [details] [review]
[PASSED QA] Bug 9986: Two fixes for Z3950 search

Searching for stdid: Standard ID, srchany: RAW (any) somehow did not work
anymore.
Probably my fault :) Note that these two fields are in Cataloging Z3950 search
and not in Acquisition.

Fixing encoding problems: When adding -utf flag for CGI in acqui/z3950 and
cataloging/z3950, the decoding statements in C4/Breeding, Z3950Search should be
removed.

Test plan:
Search in Cataloging with:
Standard ID: 9782358670043 on LOC
RAW (any): musee [add an accent aigu on first e]  on LOC  -- Add diacritic!!!

Search in Acquisition
Somewhere, does not matter, but use a diacritic.

A note: My git version still has a hard time with utf8. Need to upgrade to version 1.7.10 to resolve this..

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. No errors
Without patch z39.50 search for example Std ID OR musee gives no results,
with patch there are.
No problems in acq search.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Good catch, passes all tests and QA script.
Comment 7 Jared Camins-Esakov 2013-04-15 12:50:18 UTC
This patch has been pushed to master and 3.12.x.
Comment 8 Chris Cormack 2013-04-26 21:30:55 UTC
Does not apply to 3.10.x please send a new patch if it is needed