Bug 9989 - Closing a basket without creating a basketgroup should not redirect to baskets list
Summary: Closing a basket without creating a basketgroup should not redirect to basket...
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-04 11:35 UTC by Mathieu Saby
Modified: 2020-02-23 19:37 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9989: Stay on basket page after closing it (1.37 KB, patch)
2020-02-13 21:48 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 9989: Stay on basket page after closing it (1.38 KB, patch)
2020-02-14 16:22 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9989: Stay on basket page after closing it (1.44 KB, patch)
2020-02-14 16:59 UTC, ByWater Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-04-04 11:35:40 UTC
When we close a basket without creating a basketgroup, we are redirected to  baskets list for the vendor.
I think it would be more logical to stay on the basket page, for example if we want to put it manually into an existing basketgroup.
But maybe some libraries would prefer the current behavior?

M. Saby
Rennes 2 university
Comment 1 Aleisha Amohia 2020-02-13 21:48:50 UTC
Created attachment 98890 [details] [review]
Bug 9989: Stay on basket page after closing it

Instead of redirecting to the list of vendor's baskets.

To test:
1) Go to Acquisitions. Ensure you have a budget, fund and vendor
defined.
2) Create a basket. Add an item to it.
3) Close the basket. Do not attach to a basketgroup.
4) Notice you are redirected to the list of vendor's baskets.
5) Apply the patch and go to the basket's page. Reopen the basket.
6) Close the basket. Do not attach to a basketgroup.
7) Confirm you remain on the closed basket's page.

Sponsored-by: Catalyst IT
Comment 2 Owen Leonard 2020-02-14 16:22:23 UTC
Created attachment 98970 [details] [review]
Bug 9989: Stay on basket page after closing it

Instead of redirecting to the list of vendor's baskets.

To test:
1) Go to Acquisitions. Ensure you have a budget, fund and vendor
defined.
2) Create a basket. Add an item to it.
3) Close the basket. Do not attach to a basketgroup.
4) Notice you are redirected to the list of vendor's baskets.
5) Apply the patch and go to the basket's page. Reopen the basket.
6) Close the basket. Do not attach to a basketgroup.
7) Confirm you remain on the closed basket's page.

Sponsored-by: Catalyst IT
Comment 3 ByWater Sandboxes 2020-02-14 16:59:24 UTC
Created attachment 98980 [details] [review]
Bug 9989: Stay on basket page after closing it

Instead of redirecting to the list of vendor's baskets.

To test:
1) Go to Acquisitions. Ensure you have a budget, fund and vendor
defined.
2) Create a basket. Add an item to it.
3) Close the basket. Do not attach to a basketgroup.
4) Notice you are redirected to the list of vendor's baskets.
5) Apply the patch and go to the basket's page. Reopen the basket.
6) Close the basket. Do not attach to a basketgroup.
7) Confirm you remain on the closed basket's page.

Sponsored-by: Catalyst IT

Signed-off-by: Jessica Zairo <jzairo@bywatersolutions.com>
Comment 4 Katrin Fischer 2020-02-19 00:00:06 UTC
There is 2 places now where one can close the basket:
- From the basket summary page. I totally agree with the new redirect there.
- From the vendor search results list - This one I am not sure about. I think the old redirect works better there as it would allow you to quickly close multiple baskets.

Jessica, as you signed off, what do you think?
Comment 5 Jonathan Druart 2020-02-21 15:44:41 UTC
(In reply to Katrin Fischer from comment #4)
> There is 2 places now where one can close the basket:
> - From the basket summary page. I totally agree with the new redirect there.
> - From the vendor search results list - This one I am not sure about. I
> think the old redirect works better there as it would allow you to quickly
> close multiple baskets.
> 
> Jessica, as you signed off, what do you think?

I agree with that. Failing QA.
Comment 6 Aleisha Amohia 2020-02-23 19:30:17 UTC
I wrote a patch addressing the solution in the description of this bug. If we don't want that solution anymore, surely just close the bug report?
Comment 7 Katrin Fischer 2020-02-23 19:35:38 UTC
Hi Aleiha, 

when there was only one page where you could close the basket (the basket summary page) this made a lot of sense - and it still does. 
The problem is that a not so long while ago another page was added where you can close the basket - the 'search result' page when you search for the vendor. So the thing that was strange here, that it would not return to the page where you started from, applies now there.

Would it be possible to just return to the page where you came from?
Comment 8 Aleisha Amohia 2020-02-23 19:37:17 UTC
Ah yup understood, thanks Katrin