While translating this: %s %s [%% SET field_display_names = { surname => "Surname" firstname => "First name" title => "Title" othernames => "Other names" initials => "Initials" streetnumber => "Street number" streettype => "Street type" address => "Address" address2 => "Address 2" city => "City" state => "State" zipcode => "Zip code" country => "Country" email => "Email" phone => "Primary Phone" mobile => "Primary Mobile Phone" fax => "Fax" emailpro => "Secondary email" phonepro => "Secondary phone" B_streetnumber => "Alternate address - street number" B_streettype => "Alternate address - street type" B_address => "Alternate address" B_address2 => "Alternate address 2" B_city => "Alternate address - city" B_state => "Alternate address - state" B_zipcode => "Alternate address - zip code" B_email => "Alternate address - email" B_phone => "Alertnate address - phone" dateofbirth => "Date of birth" contactname => "Contact - last name" contactfirstname=> "Contact - first name" contacttitle => "Contact - title" relationship => "Contact - relationship" ethnicity => "Ethnicity" ethnotes => "Ethnicity notes" sex => "Sex" altcontactfirstname => "Alternate contact - first name" altcontactsurname => "Alternate contact - surname" altcontactaddress1 => "Alternate contact - address" altcontactaddress2 => "Alternate contact - address 2" altcontactaddress3 => "Alternate contact - city" altcontactstate => "Alternate contact - state" altcontactzipcode => "Alternate contact - zip code" altcontactcounty => "Alternate contact - county" altcontactphone => "Alternate contact - phone" smsalertnumber => "SMS alert number" } %%] I was wondering if altcontactcounty => "Alternate contact - county" shouldn't be country to match the field in the database?
Created attachment 17290 [details] [review] Bug 9997 - Suspected typo in patron self registration code String fix. The field name is also incorrect, causing the alternate contact country to not be stored.
Created attachment 17293 [details] [review] [SIGNED-OFF] Bug 9997 - Suspected typo in patron self registration code String fix. The field name is also incorrect, causing the alternate contact country to not be stored. To test: Submit an update to an existing patron record an include a change to the alternate contact's country field. Before the patch this line would not appear in the staff client for approval. After the patch it should. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Reminder: Even small patches require test plans. I have added one which I think covers the changes in the patch.
Created attachment 17324 [details] [review] [PASSED QA] Bug 9997 - Suspected typo in patron self registration code String fix. The field name is also incorrect, causing the alternate contact country to not be stored. To test: Submit an update to an existing patron record an include a change to the alternate contact's country field. Before the patch this line would not appear in the staff client for approval. After the patch it should. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Reminder: Even small patches require test plans. I have added one which I think covers the changes in the patch. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and QA script pass.
This patch has been pushed to master and 3.12.x.