View | Details | Raw Unified | Return to bug 38777
Collapse All | Expand All

(-)a/C4/Reserves.pm (-2 / +4 lines)
Lines 1776-1783 sub _koha_notify_reserve { Link Here
1776
            message_name => 'Hold_Filled'
1776
            message_name => 'Hold_Filled'
1777
    } );
1777
    } );
1778
1778
1779
    my $library = Koha::Libraries->find( $hold->branchcode );
1779
    my $library             = Koha::Libraries->find( $hold->branchcode );
1780
    my $from_email_address = $library->from_email_address;
1780
    my $from_email_address  = $library->from_email_address;
1781
    my $reply_email_address = $library->inbound_email_address;
1781
1782
1782
    my %letter_params = (
1783
    my %letter_params = (
1783
        module => 'reserves',
1784
        module => 'reserves',
Lines 1812-1817 sub _koha_notify_reserve { Link Here
1812
                    letter                 => $letter,
1813
                    letter                 => $letter,
1813
                    borrowernumber         => $borrowernumber,
1814
                    borrowernumber         => $borrowernumber,
1814
                    from_address           => $from_email_address,
1815
                    from_address           => $from_email_address,
1816
                    reply_address          => $reply_email_address,
1815
                    message_transport_type => $mtt,
1817
                    message_transport_type => $mtt,
1816
                }
1818
                }
1817
            );
1819
            );
(-)a/t/db_dependent/Reserves.t (-4 / +8 lines)
Lines 715-721 $cache->clear_from_cache("MarcSubfieldStructure-$frameworkcode"); Link Here
715
715
716
subtest '_koha_notify_reserve() tests' => sub {
716
subtest '_koha_notify_reserve() tests' => sub {
717
717
718
    plan tests => 3;
718
    plan tests => 4;
719
719
720
    my $branch = $builder->build_object({
720
    my $branch = $builder->build_object({
721
        class => 'Koha::Libraries',
721
        class => 'Koha::Libraries',
Lines 797-805 subtest '_koha_notify_reserve() tests' => sub { Link Here
797
            borrowernumber => $hold_borrower,
797
            borrowernumber => $hold_borrower,
798
        })->next();
798
        })->next();
799
    my $email_to_address = $email->to_address();
799
    my $email_to_address = $email->to_address();
800
    is($email_to_address, undef ,"We should not populate the hold message with the email address, sending will do so");
800
    is(
801
        $email_to_address, undef,
802
        "We should not populate the hold message with the email address, sending will do so"
803
    );
801
    my $email_from_address = $email->from_address();
804
    my $email_from_address = $email->from_address();
802
    is($email_from_address,'branch@e.mail',"Library's from address is used for sending");
805
    is( $email_from_address, 'branch@e.mail', "Library's from address is used for sending" );
806
    my $email_reply_address = $email->reply_address();
807
    is( $email_reply_address, 'branch@reply.to', "Library's reply address is used for reply" );
803
808
804
};
809
};
805
810
806
- 

Return to bug 38777