Bug 38777 - HOLD letter should use the reply to of the library that hold is waiting at
Summary: HOLD letter should use the reply to of the library that hold is waiting at
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Baptiste Wojtkowski (bwoj)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-12-23 15:59 UTC by Nick Clemens (kidclamp)
Modified: 2025-01-07 14:49 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the HOLD letter to use the reply to email address of the library the hold is waiting at instead of the patron library to ensure replies go to the correct branch for the hold.
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 38777: Use branch reply to for HOLD messages (3.31 KB, patch)
2024-12-23 16:07 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 38777: Use branch reply to for HOLD messages (3.36 KB, patch)
2024-12-24 05:25 UTC, David Nind
Details | Diff | Splinter Review
Bug 38777: Use branch reply to for HOLD messages (3.42 KB, patch)
2025-01-02 12:04 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2024-12-23 15:59:56 UTC
When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at.

We should also use this when setting the reply to.

To test:
1 - Set the email/replyto for a patron's library to be:
    patron@example.com
2 - Set the email/replyto for another branch to be:
    holdbranch@example.com
3 - Place a hold for the patron for pickup at the other branch
4 - Check in and set hold waiting
5 - SELECT * FROM message_queue
6 - Note the message is from the hold branch, but has a null replyto
    This means we will use patron branch when sending
Comment 1 Nick Clemens (kidclamp) 2024-12-23 16:07:57 UTC
Created attachment 175913 [details] [review]
Bug 38777: Use branch reply to for HOLD messages

When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at.

We should also use this when setting the reply to.

To test:
1 - Set the email/replyto for a patron's library to be:
    patron@example.com
2 - Set the email/replyto for another branch to be:
    holdbranch@example.com
3 - Place a hold for the patron for pickup at the other branch
4 - Check in and set hold waiting
5 - SELECT * FROM message_queue
6 - Note the message is from the hold branch, but has a null replyto
    This means we will use patron branch when sending
7 - Apply patch
8 - Revert hold waiting status
9 - Checkin and confirm hold again
10  -Check message queue
11 - Hold now has reply address of branch
Comment 2 David Nind 2024-12-24 05:25:11 UTC
Created attachment 175921 [details] [review]
Bug 38777: Use branch reply to for HOLD messages

When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at.

We should also use this when setting the reply to.

To test:
1 - Set the email/replyto for a patron's library to be:
    patron@example.com
2 - Set the email/replyto for another branch to be:
    holdbranch@example.com
3 - Place a hold for the patron for pickup at the other branch
4 - Check in and set hold waiting
5 - SELECT * FROM message_queue
6 - Note the message is from the hold branch, but has a null replyto
    This means we will use patron branch when sending
7 - Apply patch
8 - Revert hold waiting status
9 - Checkin and confirm hold again
10  -Check message queue
11 - Hold now has reply address of branch

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Baptiste Wojtkowski (bwoj) 2025-01-02 12:04:07 UTC
Created attachment 176054 [details] [review]
Bug 38777: Use branch reply to for HOLD messages

When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at.

We should also use this when setting the reply to.

To test:
1 - Set the email/replyto for a patron's library to be:
    patron@example.com
2 - Set the email/replyto for another branch to be:
    holdbranch@example.com
3 - Place a hold for the patron for pickup at the other branch
4 - Check in and set hold waiting
5 - SELECT * FROM message_queue
6 - Note the message is from the hold branch, but has a null replyto
    This means we will use patron branch when sending
7 - Apply patch
8 - Revert hold waiting status
9 - Checkin and confirm hold again
10  -Check message queue
11 - Hold now has reply address of branch

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Comment 4 Baptiste Wojtkowski (bwoj) 2025-01-02 12:05:02 UTC
Works as expected, Qa tools passes, changes makes sense and is proven by appropriate test, Passing QA
Comment 5 Katrin Fischer 2025-01-07 14:49:22 UTC
Pushed for 25.05!

Well done everyone, thank you!