When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at. We should also use this when setting the reply to. To test: 1 - Set the email/replyto for a patron's library to be: patron@example.com 2 - Set the email/replyto for another branch to be: holdbranch@example.com 3 - Place a hold for the patron for pickup at the other branch 4 - Check in and set hold waiting 5 - SELECT * FROM message_queue 6 - Note the message is from the hold branch, but has a null replyto This means we will use patron branch when sending
Created attachment 175913 [details] [review] Bug 38777: Use branch reply to for HOLD messages When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at. We should also use this when setting the reply to. To test: 1 - Set the email/replyto for a patron's library to be: patron@example.com 2 - Set the email/replyto for another branch to be: holdbranch@example.com 3 - Place a hold for the patron for pickup at the other branch 4 - Check in and set hold waiting 5 - SELECT * FROM message_queue 6 - Note the message is from the hold branch, but has a null replyto This means we will use patron branch when sending 7 - Apply patch 8 - Revert hold waiting status 9 - Checkin and confirm hold again 10 -Check message queue 11 - Hold now has reply address of branch
Created attachment 175921 [details] [review] Bug 38777: Use branch reply to for HOLD messages When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at. We should also use this when setting the reply to. To test: 1 - Set the email/replyto for a patron's library to be: patron@example.com 2 - Set the email/replyto for another branch to be: holdbranch@example.com 3 - Place a hold for the patron for pickup at the other branch 4 - Check in and set hold waiting 5 - SELECT * FROM message_queue 6 - Note the message is from the hold branch, but has a null replyto This means we will use patron branch when sending 7 - Apply patch 8 - Revert hold waiting status 9 - Checkin and confirm hold again 10 -Check message queue 11 - Hold now has reply address of branch Signed-off-by: David Nind <david@davidnind.com>
Created attachment 176054 [details] [review] Bug 38777: Use branch reply to for HOLD messages When sending a notice of a hold ready for pickup (not digest) we use the library where the hold is at. We should also use this when setting the reply to. To test: 1 - Set the email/replyto for a patron's library to be: patron@example.com 2 - Set the email/replyto for another branch to be: holdbranch@example.com 3 - Place a hold for the patron for pickup at the other branch 4 - Check in and set hold waiting 5 - SELECT * FROM message_queue 6 - Note the message is from the hold branch, but has a null replyto This means we will use patron branch when sending 7 - Apply patch 8 - Revert hold waiting status 9 - Checkin and confirm hold again 10 -Check message queue 11 - Hold now has reply address of branch Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Works as expected, Qa tools passes, changes makes sense and is proven by appropriate test, Passing QA
Pushed for 25.05! Well done everyone, thank you!