View | Details | Raw Unified | Return to bug 40444
Collapse All | Expand All

(-)a/xt/author/Text_CSV_Various.t (-1 / +2 lines)
Lines 24-30 use Modern::Perl; Link Here
24
use open OUT => ':encoding(UTF-8)', ':std';
24
use open OUT => ':encoding(UTF-8)', ':std';
25
use utf8;
25
use utf8;
26
26
27
use Test::More tests => 21;
27
use Test::More tests => 22;
28
use Test::NoWarnings;
28
use Text::CSV;
29
use Text::CSV;
29
use Text::CSV_XS;
30
use Text::CSV_XS;
30
31
(-)a/xt/author/codespell.t (-1 / +2 lines)
Lines 2-7 Link Here
2
use Modern::Perl;
2
use Modern::Perl;
3
use Test::PerlTidy;
3
use Test::PerlTidy;
4
use Test::More;
4
use Test::More;
5
use Test::NoWarnings;
5
6
6
use Koha::Devel::Files;
7
use Koha::Devel::Files;
7
8
Lines 17-23 push @files, $dev_files->ls_perl_files; Link Here
17
push @files, $dev_files->ls_tt_files;
18
push @files, $dev_files->ls_tt_files;
18
push @files, $dev_files->ls_js_files;
19
push @files, $dev_files->ls_js_files;
19
20
20
plan tests => scalar @files;
21
plan tests => scalar(@files) + 1;
21
22
22
for my $file (@files) {
23
for my $file (@files) {
23
    my $output = qx{codespell -d --ignore-words .codespell-ignore $file};
24
    my $output = qx{codespell -d --ignore-words .codespell-ignore $file};
(-)a/xt/author/icondirectories.t (-1 / +2 lines)
Lines 34-40 use lib qw( .. ); Link Here
34
34
35
use Data::Dumper;
35
use Data::Dumper;
36
use File::Find;
36
use File::Find;
37
use Test::More tests => 3;
37
use Test::More tests => 4;
38
use Test::NoWarnings;
38
39
39
# hardcoded OPAC & STAFF dirs
40
# hardcoded OPAC & STAFF dirs
40
my $opac_dir  = 'koha-tmpl/opac-tmpl';
41
my $opac_dir  = 'koha-tmpl/opac-tmpl';
(-)a/xt/check_makefile.t (-2 / +2 lines)
Lines 18-25 Link Here
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
use Test::More;
21
use Test::More tests => 3;
22
plan tests => 2;
22
use Test::NoWarnings;
23
23
24
use File::Spec;
24
use File::Spec;
25
use File::Slurp qw( read_file );
25
use File::Slurp qw( read_file );
(-)a/xt/find-misplaced-executables.t (-1 / +2 lines)
Lines 23-29 Link Here
23
use Modern::Perl;
23
use Modern::Perl;
24
use File::Find;
24
use File::Find;
25
use Data::Dumper;
25
use Data::Dumper;
26
use Test::More tests => 1;
26
use Test::More tests => 2;
27
use Test::NoWarnings;
27
28
28
my @files;
29
my @files;
29
30
(-)a/xt/find-missing-auth_checks.t (-2 / +2 lines)
Lines 16-22 Link Here
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
17
17
18
use Modern::Perl;
18
use Modern::Perl;
19
use Test::More;
19
use Test::More tests => 2;
20
use Test::NoWarnings;
20
21
21
use File::Slurp qw(read_file);
22
use File::Slurp qw(read_file);
22
23
Lines 39-42 FILE: foreach my $file (@files) { Link Here
39
    push @missing_auth_check, $file;
40
    push @missing_auth_check, $file;
40
}
41
}
41
is( scalar @missing_auth_check, 0 ) or diag "No auth check in the following files:\n" . join "\n", @missing_auth_check;
42
is( scalar @missing_auth_check, 0 ) or diag "No auth check in the following files:\n" . join "\n", @missing_auth_check;
42
done_testing;
(-)a/xt/find-missing-csrf.t (-1 / +2 lines)
Lines 18-24 Link Here
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
use Test::More tests => 2;
21
use Test::More tests => 3;
22
use Test::NoWarnings;
22
use File::Slurp;
23
use File::Slurp;
23
use Data::Dumper;
24
use Data::Dumper;
24
25
(-)a/xt/find-missing-filters.t (-1 / +2 lines)
Lines 16-22 Link Here
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
16
# along with Koha; if not, see <http://www.gnu.org/licenses>.
17
17
18
use Modern::Perl;
18
use Modern::Perl;
19
use Test::More tests => 2;
19
use Test::More tests => 3;
20
use Test::NoWarnings;
20
use File::Slurp qw( read_file );
21
use File::Slurp qw( read_file );
21
use Data::Dumper;
22
use Data::Dumper;
22
use t::lib::QA::TemplateFilters;
23
use t::lib::QA::TemplateFilters;
(-)a/xt/find-missing-op-in-forms.t (-1 / +2 lines)
Lines 18-24 Link Here
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
use Test::More tests => 2;
21
use Test::More tests => 3;
22
use Test::NoWarnings;
22
use File::Slurp;
23
use File::Slurp;
23
use Data::Dumper;
24
use Data::Dumper;
24
25
(-)a/xt/js_tidy.t (-1 / +2 lines)
Lines 18-27 Link Here
18
use Modern::Perl;
18
use Modern::Perl;
19
use File::Slurp qw( read_file );
19
use File::Slurp qw( read_file );
20
use Test::More;
20
use Test::More;
21
use Test::NoWarnings;
21
22
22
my @js_files = qx{git ls-files '*.js' '*.ts'};
23
my @js_files = qx{git ls-files '*.js' '*.ts'};
23
24
24
plan tests => scalar @js_files;
25
plan tests => scalar(@js_files) + 1;
25
26
26
foreach my $filepath (@js_files) {
27
foreach my $filepath (@js_files) {
27
    chomp $filepath;
28
    chomp $filepath;
(-)a/xt/perltidy.t (-1 / +2 lines)
Lines 2-14 Link Here
2
use Modern::Perl;
2
use Modern::Perl;
3
use Test::PerlTidy;
3
use Test::PerlTidy;
4
use Test::More;
4
use Test::More;
5
use Test::NoWarnings;
5
6
6
use Koha::Devel::Files;
7
use Koha::Devel::Files;
7
8
8
my $dev_files = Koha::Devel::Files->new( { context => 'tidy' } );
9
my $dev_files = Koha::Devel::Files->new( { context => 'tidy' } );
9
my @files     = $dev_files->ls_perl_files;
10
my @files     = $dev_files->ls_perl_files;
10
11
11
plan tests => scalar @files;
12
plan tests => scalar(@files) + 1;
12
13
13
for my $file (@files) {
14
for my $file (@files) {
14
    ok( Test::PerlTidy::is_file_tidy($file) );
15
    ok( Test::PerlTidy::is_file_tidy($file) );
(-)a/xt/single_quotes.t (-1 / +2 lines)
Lines 18-24 Link Here
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
18
# along with Koha; if not, see <http://www.gnu.org/licenses>.
19
19
20
use Modern::Perl;
20
use Modern::Perl;
21
use Test::More tests => 2;
21
use Test::More tests => 3;
22
use Test::NoWarnings;
22
use File::Slurp qw( read_file );
23
use File::Slurp qw( read_file );
23
24
24
use Koha::Devel::Files;
25
use Koha::Devel::Files;
(-)a/xt/use-test-no-warnings.t (-1 / +10 lines)
Lines 21-27 use Test::NoWarnings; Link Here
21
21
22
use Array::Utils qw( array_minus );
22
use Array::Utils qw( array_minus );
23
23
24
my @t_files = qx{git grep --files-without-match "Test::NoWarnings" 't/*.t'};
24
my @t_files = qx{git grep --files-without-match "Test::NoWarnings" 't/*.t' 'xt/*.t'};
25
chomp for @t_files;
25
chomp for @t_files;
26
26
27
my @exceptions = (
27
my @exceptions = (
Lines 46-51 my @exceptions = ( Link Here
46
46
47
    # bug 40443
47
    # bug 40443
48
    "t/db_dependent/cronjobs/advance_notices_digest.t",
48
    "t/db_dependent/cronjobs/advance_notices_digest.t",
49
50
    # Cannot be removed
51
    "xt/author/podcorrectness.t",
52
53
    # bug 40449
54
    "xt/author/valid-templates.t",
55
56
    # bug 40315
57
    "xt/tt_tidy.t",
49
);
58
);
50
59
51
@t_files = array_minus( @t_files, @exceptions );
60
@t_files = array_minus( @t_files, @exceptions );
(-)a/xt/verify-debian-docbook.t (-1 / +4 lines)
Lines 21-32 Link Here
21
# generates the koha-common man pages and ensures they're correct.
21
# generates the koha-common man pages and ensures they're correct.
22
22
23
use Modern::Perl;
23
use Modern::Perl;
24
use Test::More qw(no_plan);
24
use Test::More;
25
use Test::NoWarnings;
25
26
26
my $doc_dir   = 'debian/docs';
27
my $doc_dir   = 'debian/docs';
27
my @doc_files = glob( $doc_dir . '/*.xml' );
28
my @doc_files = glob( $doc_dir . '/*.xml' );
28
my @command   = qw(xmllint --noout);
29
my @command   = qw(xmllint --noout);
29
30
31
plan tests => scalar(@doc_files) + 1;
32
30
foreach my $file (@doc_files) {
33
foreach my $file (@doc_files) {
31
    ok( system( @command, $file ) == 0, "XML validation for $file" );
34
    ok( system( @command, $file ) == 0, "XML validation for $file" );
32
}
35
}
(-)a/xt/verify-yarnlock.t (-1 / +2 lines)
Lines 23-29 Link Here
23
# 'git commit ./yarn.lock'.
23
# 'git commit ./yarn.lock'.
24
24
25
use Modern::Perl;
25
use Modern::Perl;
26
use Test::More tests => 1;
26
use Test::More tests => 2;
27
use Test::NoWarnings;
27
28
28
my $rc;
29
my $rc;
29
30
(-)a/xt/verify_bib1.att.t (-1 / +2 lines)
Lines 17-23 Link Here
17
17
18
use Modern::Perl;
18
use Modern::Perl;
19
19
20
use Test::More tests => 2;
20
use Test::More tests => 3;
21
use Test::NoWarnings;
21
22
22
foreach my $record_type (qw( biblios authorities )) {
23
foreach my $record_type (qw( biblios authorities )) {
23
24
(-)a/xt/vue_tidy.t (-1 / +2 lines)
Lines 18-27 Link Here
18
use Modern::Perl;
18
use Modern::Perl;
19
use File::Slurp qw( read_file );
19
use File::Slurp qw( read_file );
20
use Test::More;
20
use Test::More;
21
use Test::NoWarnings;
21
22
22
my @vue_files = `git ls-files 'koha-tmpl/intranet-tmpl/prog/js/vue/*.vue'`;
23
my @vue_files = `git ls-files 'koha-tmpl/intranet-tmpl/prog/js/vue/*.vue'`;
23
24
24
plan tests => scalar @vue_files;
25
plan tests => scalar(@vue_files) + 1;
25
26
26
foreach my $filepath (@vue_files) {
27
foreach my $filepath (@vue_files) {
27
    chomp $filepath;
28
    chomp $filepath;
(-)a/xt/yaml_valid.t (-2 / +2 lines)
Lines 23-28 use File::Find; Link Here
23
use FindBin ();
23
use FindBin ();
24
24
25
use Test::More;
25
use Test::More;
26
use Test::NoWarnings;
26
27
27
my $filebase = "$FindBin::Bin/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences";
28
my $filebase = "$FindBin::Bin/../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences";
28
29
Lines 35-41 sub wanted { Link Here
35
}
36
}
36
find( { wanted => \&wanted, no_chdir => 1 }, $filebase );
37
find( { wanted => \&wanted, no_chdir => 1 }, $filebase );
37
38
38
plan tests => scalar @files;
39
plan tests => scalar(@files) + 1;
39
40
40
foreach my $f (@files) {
41
foreach my $f (@files) {
41
    chomp $f;
42
    chomp $f;
42
- 

Return to bug 40444