Once all children bug reports of bug 25515 will be pushed, only 7 (non-tribial) tests will be left. We should add a test now to ensure no new occurrence will be added.
Created attachment 184319 [details] [review] Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings This patch adds a new xt test (xt/use-test-no-warnings.t) to make sure all our Perl test files will use Test::NoWarnings. It also adds Test::NoWarnings to some files that were missing it and that didn't need any other changes. However we still have 7 non-trivial tests that we will consider exception for now, until they are fixed. Test plan: prove xt/use-test-no-warnings.t should return green. And all other tests modified by this patch (the qa script will do that for you) You can also test the 2 selenium tests: 1. DROP and CREATE the DB DROP DATABASE koha_kohadev; CREATE DATABASE koha_kohadev; restart_all 2. KOHA_TESTING=1 prove t/db_dependent/selenium/00-onboarding.t 3. Repeat 1 2. KOHA_TESTING=1 prove t/db_dependent/selenium/01-installation.t
Created attachment 184364 [details] [review] Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings This patch adds a new xt test (xt/use-test-no-warnings.t) to make sure all our Perl test files will use Test::NoWarnings. It also adds Test::NoWarnings to some files that were missing it and that didn't need any other changes. However we still have 7 non-trivial tests that we will consider exception for now, until they are fixed. Test plan: prove xt/use-test-no-warnings.t should return green. And all other tests modified by this patch (the qa script will do that for you) You can also test the 2 selenium tests: 1. DROP and CREATE the DB DROP DATABASE koha_kohadev; CREATE DATABASE koha_kohadev; restart_all 2. KOHA_TESTING=1 prove t/db_dependent/selenium/00-onboarding.t 3. Repeat 1 2. KOHA_TESTING=1 prove t/db_dependent/selenium/01-installation.t
Created attachment 184365 [details] [review] Bug 40444: Add Test::NoWarnings to xt tests
https://gitlab.com/koha-community/qa-test-tools/-/issues/95
Some tests fail for me, not sure if I have to do anything else after applying the patches (KTD started up with selenium, koha and KTD updated, fresh ktd pull): prove xt/use-test-no-warnings.t xt/use-test-no-warnings.t .. 1/2 # Failed test 'All Perl test files should contain Test::NoWarnings' # at xt/use-test-no-warnings.t line 61. # got: '8' # expected: '0' # The following test files should use Test::NoWarnings: # t/ImportBatch.t # t/db_dependent/Auth.t # t/db_dependent/Budgets.t # t/db_dependent/Koha/Patron.t # t/db_dependent/www/auth_values_input_www.t # t/db_dependent/www/batch.t # t/db_dependent/www/history.t # t/db_dependent/www/search_utf8.t # Looks like you failed 1 test of 2. xt/use-test-no-warnings.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- xt/use-test-no-warnings.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=2, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.04 cusr 0.03 csys = 0.08 CPU) Result: FAIL Running the QA script - several of the tests fail for me: - t/db_dependent/Patron/Borrower_Discharge.t - t/db_dependent/selenium/00-onboarding.t - t/db_dependent/selenium/01-installation.t - t/db_dependent/selenium/opac_ill_requests.t - xt/find-misplaced-executables.t - xt/use-test-no-warnings.t
(In reply to David Nind from comment #5) > Some tests fail for me, not sure if I have to do anything else after > applying the patches (KTD started up with selenium, koha and KTD updated, > fresh ktd pull): Yes, same as bug 40315, you need the patches from the dependencies of bug 25515.
I'm going to give this a QA run.. I've changed the order of the dependency tree to make it trivial for git bz to apply all the dependencies.
Created attachment 184540 [details] [review] Bug 40444: Add a test to ensure all Perl test files use Test::NoWarnings This patch adds a new xt test (xt/use-test-no-warnings.t) to make sure all our Perl test files will use Test::NoWarnings. It also adds Test::NoWarnings to some files that were missing it and that didn't need any other changes. However we still have 7 non-trivial tests that we will consider exception for now, until they are fixed. Test plan: prove xt/use-test-no-warnings.t should return green. And all other tests modified by this patch (the qa script will do that for you) You can also test the 2 selenium tests: 1. DROP and CREATE the DB DROP DATABASE koha_kohadev; CREATE DATABASE koha_kohadev; restart_all 2. KOHA_TESTING=1 prove t/db_dependent/selenium/00-onboarding.t 3. Repeat 1 2. KOHA_TESTING=1 prove t/db_dependent/selenium/01-installation.t Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 184541 [details] [review] Bug 40444: Add Test::NoWarnings to xt tests Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Created attachment 184542 [details] [review] Bug 40444: (follow-up) Remove EDI tests from the exclude list We've got those tests running without warnings now too. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
I think we're near the end of the road here.. woop woop. In my opinion, we should go with this as soon as the EDI tests that are awaiting QA are passed.
I don't see any missing dependencies now. It should be safe to push this now, I believe?
Created attachment 184612 [details] [review] Bug 40444: Add Test::NoWarnings to newly added api/v1/cash_registers.t
(In reply to Lucas Gass (lukeg) from comment #12) > I don't see any missing dependencies now. It should be safe to push this > now, I believe? Yes, go! :)
Created attachment 184708 [details] [review] Bug 40444: Fix onboarding and installer selenium tests
Nice work everyone! Pushed to main for 25.11