View | Details | Raw Unified | Return to bug 10290
Collapse All | Expand All

(-)a/t/db_dependent/VirtualShelves.t (-31 / +22 lines)
Lines 27-48 while(my $borrower = $sth->fetchrow){ Link Here
27
}
27
}
28
28
29
# Creating some biblios
29
# Creating some biblios
30
my ($biblionumber1, $biblioitemnumber1)   = AddBiblio(MARC::Record->new, '');
30
my @biblionumbers;
31
my ($biblionumber2, $biblioitemnumber2)   = AddBiblio(MARC::Record->new, '');
31
foreach(0..9) {
32
my ($biblionumber3, $biblioitemnumber3)   = AddBiblio(MARC::Record->new, '');
32
    my ($biblionumber)= AddBiblio(MARC::Record->new, '');
33
my ($biblionumber4, $biblioitemnumber4)   = AddBiblio(MARC::Record->new, '');
33
        #item number ignored
34
my ($biblionumber5, $biblioitemnumber5)   = AddBiblio(MARC::Record->new, '');
34
    push @biblionumbers, $biblionumber;
35
my ($biblionumber6, $biblioitemnumber6)   = AddBiblio(MARC::Record->new, '');
35
}
36
my ($biblionumber7, $biblioitemnumber7)   = AddBiblio(MARC::Record->new, '');
37
my ($biblionumber8, $biblioitemnumber8)   = AddBiblio(MARC::Record->new, '');
38
my ($biblionumber9, $biblioitemnumber9)   = AddBiblio(MARC::Record->new, '');
39
my ($biblionumber10, $biblioitemnumber10) = AddBiblio(MARC::Record->new, '');
40
my @biblionumbers = (
41
    $biblionumber1, $biblionumber2, $biblionumber3, $biblionumber4, $biblionumber5,
42
    $biblionumber6, $biblionumber7, $biblionumber8, $biblionumber9, $biblionumber10,
43
);
44
36
45
# ---
37
# FIXME Why are you deleting my shelves? See bug 10386.
46
my $delete_virtualshelf = q{
38
my $delete_virtualshelf = q{
47
    DELETE FROM  virtualshelves WHERE 1
39
    DELETE FROM  virtualshelves WHERE 1
48
};
40
};
Lines 82-90 ok(10 == scalar @shelves, 'created 10 lists'); # 10 shelves in @shelves; Link Here
82
# try to create some shelf which already exists.
74
# try to create some shelf which already exists.
83
for(my $i=0;$i<10;$i++){
75
for(my $i=0;$i<10;$i++){
84
    my @shlf=GetShelf($shelves[$i]);
76
    my @shlf=GetShelf($shelves[$i]);
85
    my $badNumShelf = AddShelf(
77
86
    {shelfname=>"Shelf_".$i, category=>$shlf[3] }, $borrowers[$i]);
78
    # FIXME This test still needs some attention
87
    ok(-1 == $badNumShelf, 'do not create lists with duplicate names');   # AddShelf returns -1 if name already exist.
79
    # A shelf name is not per se unique ! See report 10386
80
    #temporary hack: Original test only for public list
81
    if( $shlf[3]==2 ) {
82
        my $badNumShelf= AddShelf(
83
            {shelfname=>"Shelf_".$i, category => 2}, $borrowers[$i]);
84
        ok(-1==$badNumShelf, 'do not create public lists with duplicate names');
85
            #AddShelf returns -1 if name already exist.
86
    }
87
    else {
88
        ok(1==1, "This trivial test cannot fail :)"); #leave count intact
89
    }
88
}
90
}
89
91
90
#-----------TEST AddToShelf & GetShelfContents &  DelFromShelf functions--------------#
92
#-----------TEST AddToShelf & GetShelfContents &  DelFromShelf functions--------------#
Lines 147-161 for(my $i=0; $i<10;$i++){ Link Here
147
    ok(1 == $status, "deleted shelf $shelfnumber and its contents");
149
    ok(1 == $status, "deleted shelf $shelfnumber and its contents");
148
}
150
}
149
151
150
END {
152
#----------------------- CLEANUP ----------------------------------------------#
151
    DelBiblio( $biblionumber1 );
153
DelBiblio($_) for @biblionumbers;
152
    DelBiblio( $biblionumber2 );
153
    DelBiblio( $biblionumber3 );
154
    DelBiblio( $biblionumber4 );
155
    DelBiblio( $biblionumber5 );
156
    DelBiblio( $biblionumber6 );
157
    DelBiblio( $biblionumber7 );
158
    DelBiblio( $biblionumber8 );
159
    DelBiblio( $biblionumber9 );
160
    DelBiblio( $biblionumber10 );
161
};
162
- 

Return to bug 10290