t/db_dependent/VirtualShelves.t depends on the Jenkins database. We should create the data we want and delete them at the end.
Created attachment 18253 [details] [review] MT10290: UT: VirtualShelves.t needs to create its own data Try before the patch: prove t/db_dependent/VirtualShelves.t And after, it should produce: t/db_dependent/VirtualShelves.t .. ok All tests successful. Files=1, Tests=82, 6 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.52 CPU) Result: PASS
Created attachment 18398 [details] [review] Bug 10290: UT: VirtualShelves.t needs to create its own data Try before the patch: prove t/db_dependent/VirtualShelves.t And after, it should produce: t/db_dependent/VirtualShelves.t .. ok All tests successful. Files=1, Tests=82, 6 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
QA: Looking at this one now.
Created attachment 18623 [details] [review] Bug 10290: Followup for Virtualshelves.t Put the 10 biblionumbers in a list Add a FIXME for deleting shelves Do temporary repair on duplicate name test (Followup via report 10386) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 18624 [details] [review] Bug 10290: UT: VirtualShelves.t needs to create its own data Try before the patch: prove t/db_dependent/VirtualShelves.t And after, it should produce: t/db_dependent/VirtualShelves.t .. ok All tests successful. Files=1, Tests=82, 6 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Created attachment 18625 [details] [review] Bug 10290: Followup for Virtualshelves.t Put the 10 biblionumbers in a list Add a FIXME for deleting shelves Do temporary repair on duplicate name test (Followup via report 10386) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Works as advertised. Leaving me only with the question if the borrowers from Jenkins are better than the biblios :) Note that if I test with a small testdb without 10 borrowernumbers, some tests do also fail.. I have added a QA followup for the 10 biblionumbers in a list. And I fixed the sometimes failing test on duplicate list name. Will continue that fix under report 10386. Plus a fixme on why all my lists have been deleted :) Galen: If you feel that this second QA followup still needs another signoff, please indicate so. Passed QA
Pushed to master. Thanks, Jonathan and Marcel!
This patch has been pushed to 3.12.x, will be in 3.12.1. I find them useful and am willing to have them in the stable branch (the same applies for the related ones if they get into master).
Pushed to 3.10.x, will be in 3.10.8
Pushed to 3.8.x, will be in 3.8.17