|
Lines 1220-1226
subtest 'request_transfer() tests' => sub {
Link Here
|
| 1220 |
ok( $original_transfer->datecancelled, "Original transfer cancelled" ); |
1220 |
ok( $original_transfer->datecancelled, "Original transfer cancelled" ); |
| 1221 |
is( $original_transfer->cancellation_reason, "WrongTransfer", "Original cancellation_reason set correctly" ); |
1221 |
is( $original_transfer->cancellation_reason, "WrongTransfer", "Original cancellation_reason set correctly" ); |
| 1222 |
$transfers = $item->get_transfers; |
1222 |
$transfers = $item->get_transfers; |
| 1223 |
is( $transfers->count, 1, "There is only 1 live transfer in the queue" ); |
1223 |
is( $transfers->count, 2, "There are 2 transfers in the queue (1 cancelled, 1 active) (Bug 28527)" ); |
| 1224 |
$replaced_transfer->datearrived(dt_from_string)->store(); |
1224 |
$replaced_transfer->datearrived(dt_from_string)->store(); |
| 1225 |
|
1225 |
|
| 1226 |
# BranchTransferLimits |
1226 |
# BranchTransferLimits |
|
Lines 1827-1833
subtest 'get_transfer' => sub {
Link Here
|
| 1827 |
}; |
1827 |
}; |
| 1828 |
|
1828 |
|
| 1829 |
subtest 'get_transfers' => sub { |
1829 |
subtest 'get_transfers' => sub { |
| 1830 |
plan tests => 17; |
1830 |
plan tests => 18; |
| 1831 |
$schema->storage->txn_begin; |
1831 |
$schema->storage->txn_begin; |
| 1832 |
|
1832 |
|
| 1833 |
my $item = $builder->build_sample_item(); |
1833 |
my $item = $builder->build_sample_item(); |
|
Lines 1954-1968
subtest 'get_transfers' => sub {
Link Here
|
| 1954 |
|
1954 |
|
| 1955 |
$transfer_1->datecancelled( \'NOW()' )->store; |
1955 |
$transfer_1->datecancelled( \'NOW()' )->store; |
| 1956 |
$transfers = $item->get_transfers(); |
1956 |
$transfers = $item->get_transfers(); |
| 1957 |
is( $transfers->count, 1, 'Once a transfer is cancelled, it no longer appears in the list from ->get_transfers()' ); |
1957 |
is( |
|
|
1958 |
$transfers->count, 2, |
| 1959 |
'Once a transfer is cancelled, it still appears in the list from ->get_transfers() (Bug 28527)' |
| 1960 |
); |
| 1958 |
$result_1 = $transfers->next; |
1961 |
$result_1 = $transfers->next; |
|
|
1962 |
$result_2 = $transfers->next; |
| 1959 |
is( |
1963 |
is( |
| 1960 |
$result_1->branchtransfer_id, $transfer_3->branchtransfer_id, |
1964 |
$result_1->branchtransfer_id, $transfer_1->branchtransfer_id, |
| 1961 |
'Koha::Item->get_transfers returns the only transfer that remains' |
1965 |
'Koha::Item->get_transfers returns cancelled transfers' |
|
|
1966 |
); |
| 1967 |
is( |
| 1968 |
$result_2->branchtransfer_id, $transfer_3->branchtransfer_id, |
| 1969 |
'Koha::Item->get_transfers returns the active transfer' |
| 1962 |
); |
1970 |
); |
| 1963 |
|
1971 |
|
| 1964 |
subtest "Ensure prefetches don't affect the return order" => sub { |
1972 |
subtest "Ensure prefetches don't affect the return order" => sub { |
| 1965 |
plan tests => 13; |
1973 |
plan tests => 14; |
| 1966 |
|
1974 |
|
| 1967 |
# Reset test data |
1975 |
# Reset test data |
| 1968 |
$transfer_2->datesent(undef)->store; |
1976 |
$transfer_2->datesent(undef)->store; |
|
Lines 2049-2061
subtest 'get_transfers' => sub {
Link Here
|
| 2049 |
)->next; |
2057 |
)->next; |
| 2050 |
$transfers = $prefetched_item->get_transfers(); |
2058 |
$transfers = $prefetched_item->get_transfers(); |
| 2051 |
is( |
2059 |
is( |
| 2052 |
$transfers->count, 1, |
2060 |
$transfers->count, 2, |
| 2053 |
'Once a transfer is cancelled, it no longer appears in the list from ->get_transfers()' |
2061 |
'Once a transfer is cancelled, it still appears in the list from ->get_transfers() (Bug 28527)' |
| 2054 |
); |
2062 |
); |
| 2055 |
$result_1 = $transfers->next; |
2063 |
$result_1 = $transfers->next; |
|
|
2064 |
$result_2 = $transfers->next; |
| 2056 |
is( |
2065 |
is( |
| 2057 |
$result_1->branchtransfer_id, $transfer_3->branchtransfer_id, |
2066 |
$result_1->branchtransfer_id, $transfer_1->branchtransfer_id, |
| 2058 |
'Koha::Item->get_transfers returns the only transfer that remains' |
2067 |
'Koha::Item->get_transfers returns cancelled transfers' |
|
|
2068 |
); |
| 2069 |
is( |
| 2070 |
$result_2->branchtransfer_id, $transfer_3->branchtransfer_id, |
| 2071 |
'Koha::Item->get_transfers returns the active transfer' |
| 2059 |
); |
2072 |
); |
| 2060 |
}; |
2073 |
}; |
| 2061 |
|
2074 |
|