Bug 28527 - Transfers that are cancelled whilst in transit should still appear as 'in transit' until they are received
Summary: Transfers that are cancelled whilst in transit should still appear as 'in tra...
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff Client (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Martin Renvoize
QA Contact: Testopia
URL:
Keywords:
Depends on: 28294 28520
Blocks: 22160
  Show dependency treegraph
 
Reported: 2021-06-08 11:07 UTC by Martin Renvoize
Modified: 2021-06-09 13:34 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 28527: Restore cancellation of transfers from Koha::Hold (1.31 KB, patch)
2021-06-09 13:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28527: Update detail to display cancelled in transit transfers (2.43 KB, patch)
2021-06-09 13:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28527: Deal with cancelled in transfer transfers when enqueueing (2.55 KB, patch)
2021-06-09 13:33 UTC, Martin Renvoize
Details | Diff | Splinter Review
Bug 28527: Add handling for cancelled in transit transfers at checkin (6.39 KB, patch)
2021-06-09 13:33 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2021-06-08 11:07:05 UTC
If a transfer is cancelled whilst it is in transit (datesent set, but datearrived not) then we should still return it as in transit.

Bug 27993 added a condition to the 'in_transit' boolean which should be reverted.
We should also update the get_transfer (and get_transfers) methods to catch such cases and return those still active transfers and deal with them appropriately at check-in. (i.e. invoke the reverse transfer or pick the next transfer from the queue and notify the librarian of what subsequent actions they should take).
Comment 1 Martin Renvoize 2021-06-08 11:59:52 UTC
Bug 28520 is very specific for the Reserve/Holds case, but does not account for transfers triggered by other means or cancelled by other means.
Comment 2 Martin Renvoize 2021-06-09 13:33:36 UTC
Created attachment 121739 [details] [review]
Bug 28527: Restore cancellation of transfers from Koha::Hold

This aptch restores the cancellation of the transfers in transit when a
hold is cancelled.
Comment 3 Martin Renvoize 2021-06-09 13:33:39 UTC
Created attachment 121740 [details] [review]
Bug 28527: Update detail to display cancelled in transit transfers
Comment 4 Martin Renvoize 2021-06-09 13:33:43 UTC
Created attachment 121741 [details] [review]
Bug 28527: Deal with cancelled in transfer transfers when enqueueing

Addeding to the queue should be allowed when the active transfer
(in_transit) has been cancelled.
Comment 5 Martin Renvoize 2021-06-09 13:33:46 UTC
Created attachment 121742 [details] [review]
Bug 28527: Add handling for cancelled in transit transfers at checkin