If a transfer is cancelled whilst it is in transit (datesent set, but datearrived not) then we should still return it as in transit.
Bug 27993 added a condition to the 'in_transit' boolean which should be reverted.
We should also update the get_transfer (and get_transfers) methods to catch such cases and return those still active transfers and deal with them appropriately at check-in. (i.e. invoke the reverse transfer or pick the next transfer from the queue and notify the librarian of what subsequent actions they should take).
Bug 28520 is very specific for the Reserve/Holds case, but does not account for transfers triggered by other means or cancelled by other means.
Created attachment 121739 [details] [review]
Bug 28527: Restore cancellation of transfers from Koha::Hold
This aptch restores the cancellation of the transfers in transit when a
hold is cancelled.
Created attachment 121740 [details] [review]
Bug 28527: Update detail to display cancelled in transit transfers
Created attachment 121741 [details] [review]
Bug 28527: Deal with cancelled in transfer transfers when enqueueing
Addeding to the queue should be allowed when the active transfer
(in_transit) has been cancelled.
Created attachment 121742 [details] [review]
Bug 28527: Add handling for cancelled in transit transfers at checkin