|
Lines 1220-1226
subtest 'request_transfer() tests' => sub {
Link Here
|
| 1220 |
ok( $original_transfer->datecancelled, "Original transfer cancelled" ); |
1220 |
ok( $original_transfer->datecancelled, "Original transfer cancelled" ); |
| 1221 |
is( $original_transfer->cancellation_reason, "WrongTransfer", "Original cancellation_reason set correctly" ); |
1221 |
is( $original_transfer->cancellation_reason, "WrongTransfer", "Original cancellation_reason set correctly" ); |
| 1222 |
$transfers = $item->get_transfers; |
1222 |
$transfers = $item->get_transfers; |
| 1223 |
is( $transfers->count, 1, "There is only 1 live transfer in the queue" ); |
1223 |
is( $transfers->count, 2, "There are 2 transfers in the queue (1 cancelled, 1 active) (Bug 28527)" ); |
| 1224 |
$replaced_transfer->datearrived(dt_from_string)->store(); |
1224 |
$replaced_transfer->datearrived(dt_from_string)->store(); |
| 1225 |
|
1225 |
|
| 1226 |
# BranchTransferLimits |
1226 |
# BranchTransferLimits |
|
Lines 1850-1856
subtest 'get_transfer' => sub {
Link Here
|
| 1850 |
}; |
1850 |
}; |
| 1851 |
|
1851 |
|
| 1852 |
subtest 'get_transfers' => sub { |
1852 |
subtest 'get_transfers' => sub { |
| 1853 |
plan tests => 17; |
1853 |
plan tests => 18; |
| 1854 |
$schema->storage->txn_begin; |
1854 |
$schema->storage->txn_begin; |
| 1855 |
|
1855 |
|
| 1856 |
my $item = $builder->build_sample_item(); |
1856 |
my $item = $builder->build_sample_item(); |
|
Lines 1977-1991
subtest 'get_transfers' => sub {
Link Here
|
| 1977 |
|
1977 |
|
| 1978 |
$transfer_1->datecancelled( \'NOW()' )->store; |
1978 |
$transfer_1->datecancelled( \'NOW()' )->store; |
| 1979 |
$transfers = $item->get_transfers(); |
1979 |
$transfers = $item->get_transfers(); |
| 1980 |
is( $transfers->count, 1, 'Once a transfer is cancelled, it no longer appears in the list from ->get_transfers()' ); |
1980 |
is( |
|
|
1981 |
$transfers->count, 2, |
| 1982 |
'Once a transfer is cancelled, it still appears in the list from ->get_transfers() (Bug 28527)' |
| 1983 |
); |
| 1981 |
$result_1 = $transfers->next; |
1984 |
$result_1 = $transfers->next; |
|
|
1985 |
$result_2 = $transfers->next; |
| 1982 |
is( |
1986 |
is( |
| 1983 |
$result_1->branchtransfer_id, $transfer_3->branchtransfer_id, |
1987 |
$result_1->branchtransfer_id, $transfer_1->branchtransfer_id, |
| 1984 |
'Koha::Item->get_transfers returns the only transfer that remains' |
1988 |
'Koha::Item->get_transfers returns cancelled transfers' |
|
|
1989 |
); |
| 1990 |
is( |
| 1991 |
$result_2->branchtransfer_id, $transfer_3->branchtransfer_id, |
| 1992 |
'Koha::Item->get_transfers returns the active transfer' |
| 1985 |
); |
1993 |
); |
| 1986 |
|
1994 |
|
| 1987 |
subtest "Ensure prefetches don't affect the return order" => sub { |
1995 |
subtest "Ensure prefetches don't affect the return order" => sub { |
| 1988 |
plan tests => 13; |
1996 |
plan tests => 14; |
| 1989 |
|
1997 |
|
| 1990 |
# Reset test data |
1998 |
# Reset test data |
| 1991 |
$transfer_2->datesent(undef)->store; |
1999 |
$transfer_2->datesent(undef)->store; |
|
Lines 2072-2084
subtest 'get_transfers' => sub {
Link Here
|
| 2072 |
)->next; |
2080 |
)->next; |
| 2073 |
$transfers = $prefetched_item->get_transfers(); |
2081 |
$transfers = $prefetched_item->get_transfers(); |
| 2074 |
is( |
2082 |
is( |
| 2075 |
$transfers->count, 1, |
2083 |
$transfers->count, 2, |
| 2076 |
'Once a transfer is cancelled, it no longer appears in the list from ->get_transfers()' |
2084 |
'Once a transfer is cancelled, it still appears in the list from ->get_transfers() (Bug 28527)' |
| 2077 |
); |
2085 |
); |
| 2078 |
$result_1 = $transfers->next; |
2086 |
$result_1 = $transfers->next; |
|
|
2087 |
$result_2 = $transfers->next; |
| 2079 |
is( |
2088 |
is( |
| 2080 |
$result_1->branchtransfer_id, $transfer_3->branchtransfer_id, |
2089 |
$result_1->branchtransfer_id, $transfer_1->branchtransfer_id, |
| 2081 |
'Koha::Item->get_transfers returns the only transfer that remains' |
2090 |
'Koha::Item->get_transfers returns cancelled transfers' |
|
|
2091 |
); |
| 2092 |
is( |
| 2093 |
$result_2->branchtransfer_id, $transfer_3->branchtransfer_id, |
| 2094 |
'Koha::Item->get_transfers returns the active transfer' |
| 2082 |
); |
2095 |
); |
| 2083 |
}; |
2096 |
}; |
| 2084 |
|
2097 |
|