Attachment #72343 for bug #20251

View | Details | Raw Unified | Return to bug 20251
Collapse All | Expand All

Lines 67-73 sub new { Link Here

(-)a/C4/SIP/ILS/Patron.pm (-2 lines)
67	{	67	{
68	no warnings; # any of these $kp->{fields} being concat'd could be undef	68	no warnings; # any of these $kp->{fields} being concat'd could be undef
69	%ilspatron = (	69	%ilspatron = (
70	getmemberdetails_object => $kp,
71	name => $kp->{firstname} . " " . $kp->{surname},	70	name => $kp->{firstname} . " " . $kp->{surname},
72	id => $kp->{cardnumber}, # to SIP, the id is the BARCODE, not userid	71	id => $kp->{cardnumber}, # to SIP, the id is the BARCODE, not userid
73	password => $pw,	72	password => $pw,
Lines 164-170 my %fields = ( Link Here
164	recall_overdue => 0, # for patron_status[12]	163	recall_overdue => 0, # for patron_status[12]
165	too_many_billed => 0, # for patron_status[13]	164	too_many_billed => 0, # for patron_status[13]
166	inet => 0, # EnvisionWare extension	165	inet => 0, # EnvisionWare extension
167	getmemberdetails_object => 0,
168	);	166	);
169		167
170	our $AUTOLOAD;	168	our $AUTOLOAD;




	my $patron_barcode = $self->{patron}->id;
        my $overridden_duedate; # usually passed as undef to AddIssue
	$debug and warn "do_checkout: patron (" . $patron_barcode . ")";
    my $patron = Koha::Patrons->find( { cardnumber => $patron_barcode } );
    my $borrower = $patron->unblessed;
	$debug and warn "do_checkout borrower: . " . Dumper $borrower;
    my ($issuingimpossible, $needsconfirmation) = _can_we_issue($patron, $barcode,
        C4::Context->preference("AllowItemsOnHoldCheckout")
    );


}

sub _can_we_issue {
    my ( $patron, $barcode, $pref ) = @_;

    my ( $issuingimpossible, $needsconfirmation, $alerts ) =
      CanBookBeIssued( $patron, $barcode, undef, 0, $pref );
    for my $href ( $issuingimpossible, $needsconfirmation ) {

        # some data is returned using lc keys we only
- 

Return to bug 20251

Lines 54-62 sub do_checkout { Link Here

(-)a/C4/SIP/ILS/Transaction/Checkout.pm (-5 / +5 lines)
54	my $patron_barcode = $self->{patron}->id;	54	my $patron_barcode = $self->{patron}->id;
55	my $overridden_duedate; # usually passed as undef to AddIssue	55	my $overridden_duedate; # usually passed as undef to AddIssue
56	$debug and warn "do_checkout: patron (" . $patron_barcode . ")";	56	$debug and warn "do_checkout: patron (" . $patron_barcode . ")";
57	my $borrower = $self->{patron}->getmemberdetails_object();	57	my $patron = Koha::Patrons->find( { cardnumber => $patron_barcode } );
		58	my $borrower = $patron->unblessed;
58	$debug and warn "do_checkout borrower: . " . Dumper $borrower;	59	$debug and warn "do_checkout borrower: . " . Dumper $borrower;
59	my ($issuingimpossible, $needsconfirmation) = _can_we_issue($borrower, $barcode,	60	my ($issuingimpossible, $needsconfirmation) = _can_we_issue($patron, $barcode,
60	C4::Context->preference("AllowItemsOnHoldCheckout")	61	C4::Context->preference("AllowItemsOnHoldCheckout")
61	);	62	);
62		63
Lines 149-158 sub do_checkout { Link Here
149	}	150	}
150		151
151	sub _can_we_issue {	152	sub _can_we_issue {
152	my ( $borrower, $barcode, $pref ) = @_;	153	my ( $patron, $barcode, $pref ) = @_;
153		154
154	my ( $issuingimpossible, $needsconfirmation, $alerts ) =	155	my ( $issuingimpossible, $needsconfirmation, $alerts ) =
155	CanBookBeIssued( $borrower, $barcode, undef, 0, $pref );	156	CanBookBeIssued( $patron, $barcode, undef, 0, $pref );
156	for my $href ( $issuingimpossible, $needsconfirmation ) {	157	for my $href ( $issuingimpossible, $needsconfirmation ) {
157		158
158	# some data is returned using lc keys we only	159	# some data is returned using lc keys we only
159	-