Attachment 101319 Details for Bug 24918 – Bug 24918: Fix attribute mappings in Koha::Acquisition::Basket

[patch] Bug 24918: Fix attribute mappings in Koha::Acquisition::Basket

Bug-24918-Fix-attribute-mappings-in-KohaAcquisitio.patch (text/plain), 1.67 KB, created by Tomás Cohen Arazi (tcohen) on 2020-03-20 19:09:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-03-20 19:09:53 UTC

Size: 1.67 KB

patch

obsolete

>From 0d50497465890a58dbe98c68eae6050e7c5dfe99 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 20 Mar 2020 16:05:46 -0300
>Subject: [PATCH] Bug 24918: Fix attribute mappings in
> Koha::Acquisition::Basket
>
>When bug 18731 was written, the official vote on the RFC hadn't been
>held yet. Once it got voted, the mappings were adapted and all the
>dependent work fixed as well. But three attribute names were overlooked
>and they become evident on developing 20212 which required them.
>
>This patch fixes this really tiny mistake.
>
>To test:
>1. Just verify the voted attribute names.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> Koha/Acquisition/Basket.pm | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/Koha/Acquisition/Basket.pm b/Koha/Acquisition/Basket.pm
>index 65d9e16d5e..39b28996e8 100644
>--- a/Koha/Acquisition/Basket.pm
>+++ b/Koha/Acquisition/Basket.pm
>@@ -125,11 +125,11 @@ sub to_api_mapping {
>         creationdate            => 'creation_date',
>         closedate               => 'close_date',
>         booksellerid            => 'vendor_id',
>-        authorisedby            => 'authorised_by',
>+        authorisedby            => 'creator_id',
>         booksellerinvoicenumber => undef,
>         basketgroupid           => 'basket_group_id',
>-        deliveryplace           => 'delivery_place',
>-        billingplace            => 'billing_place',
>+        deliveryplace           => 'delivery_library_id',
>+        billingplace            => 'billing_library_id',
>         branch                  => 'library_id',
>         is_standing             => 'standing'
>     };
>-- 
>2.25.2

Actions: View | Diff | Splinter Review

Attachments on bug 24918: 101318 | 101319 | 101412